Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: devtool select img element #538

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

xxrlzzz
Copy link
Contributor

@xxrlzzz xxrlzzz commented Dec 14, 2023

Support select img element in chrome devtool

before:
https://github.com/openwebf/webf/assets/40893153/acfff80b-ba0f-4c08-90be-6d4200b55430

after:

after.mov

@andycall
Copy link
Member

@xxrlzzz The CI reports lint errors:

Analyzing webf...                                               

   info • The import of 'rendering/root.dart' is unnecessary because all of the used elements are also provided by the import of 'package:webf/svg.dart' • lib/src/svg/svg.dart:12:8 • unnecessary_import
   info • The import of 'package:webf/src/svg/rendering/root.dart' is unnecessary because all of the used elements are also provided by the import of 'package:webf/svg.dart' 

@andycall
Copy link
Member

image

@andycall
Copy link
Member

../lib/src/rendering/box_model.dart:56:58: Error: Undefined name 'transform'.
      parentRenderer.applyLayoutTransform(childRenderer, transform, excludeScrollOffset);

@andycall
Copy link
Member

@xxrlzzz You can try npm run lint to check that linter.

@xxrlzzz
Copy link
Contributor Author

xxrlzzz commented Dec 20, 2023

../lib/src/rendering/box_model.dart:56:58: Error: Undefined name 'transform'.
      parentRenderer.applyLayoutTransform(childRenderer, transform, excludeScrollOffset);

this line of code was introduced by 64cd037 , rather than this commit.

ci failed after commit fix: sliver layout child boundingClientRect offset error,

@andycall
Copy link
Member

Fixed due to some changes conflict with other PR, please sync with main and try again.

@jinwencan
Copy link
Contributor

lgtm

@jinwencan jinwencan added this pull request to the merge queue Dec 20, 2023
Merged via the queue into openwebf:main with commit 31a8928 Dec 20, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants