-
-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: devtool select img element #538
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andycall
reviewed
Dec 14, 2023
andycall
approved these changes
Dec 14, 2023
xxrlzzz
force-pushed
the
feat/devtool_select_img
branch
from
December 15, 2023 07:43
b93e19f
to
e8e7096
Compare
@xxrlzzz The CI reports lint errors:
|
xxrlzzz
force-pushed
the
feat/devtool_select_img
branch
from
December 18, 2023 03:25
e8e7096
to
d33fb51
Compare
|
@xxrlzzz You can try |
this line of code was introduced by 64cd037 , rather than this commit. ci failed after commit |
Fixed due to some changes conflict with other PR, please sync with main and try again. |
lgtm |
jinwencan
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support select img element in chrome devtool
before:
https://github.com/openwebf/webf/assets/40893153/acfff80b-ba0f-4c08-90be-6d4200b55430
after:
after.mov