feat: add support for AbortController. #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-clang
approved these changes
May 19, 2024
| @override | ||
| String invoke(String method, params, InvokeModuleCallback callback) { | ||
| if (method == 'abortRequest') { | ||
| _abortRequest(); | ||
| return ''; |
There was a problem hiding this comment.
return EMPTY_STRING is better ?
| @@ -223,7 +230,7 @@ export class Request extends Body { | |||
| // readonly redirect: RequestRedirect; // not supported | |||
| // readonly referrer: string; // not supported | |||
| // readonly referrerPolicy: ReferrerPolicy; | |||
| // readonly signal: AbortSignal; // not supported | |||
| readonly signal: AbortSignal; // not supported | |||
There was a problem hiding this comment.
// not supported should be deleted
pba-cra
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/API/AbortController