-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce incorrectly removes parenthesis in mathobject string. #634
Comments
This turns out to be a bad interaction between two different reduction rules. I have made a pull request to fix it (linked above). |
Thanks, I can confirm this fixes the issue. @dpvc I notice you only have a pull request for |
I will let others make that call. I'm not up on the release process any more. If so, then the PR should be rebased to |
@dpvc: That is pretty much it. Rebase and retarget. I am not sure if this should be a hotfix or not. I am not certain that is so pressing. It is really a display issue, and those are usually things that we defer to the next release. What do others think? |
@drgrice1 The reason I think it should be put in main is because although the original mathobject is correct, the string is used to build future mathobjects, so any mathobject built using this mathobject, such as |
The only time it would be a computation issue is if the reduced function is then inserted into another string (for |
As @dpvc pointed out, it has been that way for a long time. We can't just run to put in a hotfix every time a minor issue comes up. It won't work in further computations, so work around it for now. There are other ways to do it. |
Thanks for the clarification. |
Again, I am waiting on other opinions. So if the general consensus is that this is hotfix worthy, then we will put it in. |
I think, also, we can wait for the next release. I'm not sure how many people pull in hot fixes to their servers anyway and it's not a security bug. @somiaj , maybe make a post on the forum discussing this so people are aware. |
Remove noParens marker from operand (if any) when reducing double negatives. #634
Fixed with #635. |
When using reduce (with a double negative) parenthesis are removed from the
->string
. Here is my test caseThis causes the
->string
to loose the parenthesis , but->TeX
is fine.I think this is related to a similar bug, but it wasn't fully fixed in issue #455 and the pull request #546.
The text was updated successfully, but these errors were encountered: