Fix checks for scalar multiplication to not have to stringify the val… #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix checks for scalar multiplication (for points, vectors, and matrices) to not have to stringify the value if it is already a Real or Complex number. This resolves bug 3991. The issue was that when
Context()->texStrings
is in effect, the string match that was used to decide if the coefficient is a number would match against the TeX version of the number. When the number is large enough for scientific notation (i.e., more than 6 digits), then the TeX version of scientific notation would not match as a number, and would give an error.To test the patch, use
Without the patch, all the lines involving
$a
should produce an error, but the ones with$b
should be markedOK
. With the patch, all the lines should beOK
.