Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors caused by bad merge of tableau.pl #425

Merged
merged 2 commits into from
Sep 26, 2019

Conversation

mgage
Copy link
Member

@mgage mgage commented Sep 25, 2019

Hopefully this fixes a garbled tableau.pl file (resulting from a failed merge) that Glenn Rice caught.

@mgage mgage requested a review from drgrice1 September 26, 2019 12:40
@drgrice1
Copy link
Member

drgrice1 commented Sep 26, 2019

It is probably good to get this file back in working order. The tableau_javascript.pg test problem works again with this. There seem to be problems with the javascript in the quickMatrixEntry.pl file that causes "undefined" to appear in the textarea of the dialog for each row of the matrix.

It may not be worth the attention at this point. None of the files in the open problem library use tableau.pl or quickMatrixEntry.pl.

Of course, there may be others using these files in problems not in the library. So this fixed version should be pulled in in any case.

@mgage mgage merged commit 9652784 into openwebwork:PG-2.15 Sep 26, 2019
@mgage
Copy link
Member Author

mgage commented Sep 26, 2019

I agree the quickMatrixEntry javascript could use more work. In addition to cosmetic problems I would like the quickMatrixEntry to hand a variety of matrix input styles. As it is it handles matrices represented in rows with space separation between entries and a \n to indicate the end of the row. This is the format that websim uses. I would like it to handle MatLab formats and Mathematica formats and perhaps other formats as well.

@mgage mgage deleted the PG-2.15-fix-tableau-merge branch May 19, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants