Make sure negative numbers are handled as a negated number in Value items (#658) #659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the problem where substituting a negative constant into a formula might not get the needed parentheses. It does so by providing a proper tree structure (negation together with a number) so that the parentheses are inserted when needed.
You can test using
which should produce
(-3)^y
rather than-3^y
, whileshould produce
-3+y
(not(-3)+y
).Similarly,
should produce
3^y
, as expected.Resolves issue #658.