Implement workaround for JSXGraph issue with points created off the board. #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Jordan
approved these changes
Jun 12, 2023
…oard. If a point is created off the board with `snapSizeGrid` true, then the coordinate that is outside of the board's bounding box range is moved one snap size unit toward the bounding box range. See jsxgraph/jsxgraph#545 for issues on this bug in JSXGraph. To fix this points need to be created with `snapToGrid` false (the default value), and then that attribute set to true afterward. In order for this to work the coordinates of the point need to be manually rounded to the snap size. This is only done for initial creation of objects (answers or static objects). It does not need to be done for objects that are created dynamically (by student interaction) since those points are forced to be on the board anyway. This is also not done for 'point' graph tool objects, since the correct answer should not be a point off the board anyway. This workaround fixes issue openwebwork#849.
drgrice1
force-pushed
the
bugfix/graphtool-point-off-board
branch
from
bd9025b
to
8fd1f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a point is created off the board with
snapSizeGridtrue, then the coordinate that is outside of the board's bounding box range is moved one snap size unit toward the bounding box range. See jsxgraph/jsxgraph#545 for issues on this bug in JSXGraph.To fix this points need to be created with
snapToGridfalse (the default value), and then that attribute set to true afterward. In order for this to work the coordinates of the point need to be manually rounded to the snap size.This is only done for initial creation of objects (answers or static objects). It does not need to be done for objects that are created dynamically (by student interaction) since those points are forced to be on the board anyway. This is also not done for 'point' graph tool objects, since the correct answer should not be a point off the board anyway.
This workaround fixes issue #849.