Warn if a macro file has a POD directive on the first line but don't fail. #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fail. This adds a new line to the beginning of the code for a macro file that starts with `=` which will usually mean an invalid POD directive on the first line of the file (and is invalid in any case for the first character of a Perl file). In that case a warning is also shown. This warning will only be shown if the view_problem_debugging_info flag is set (this corresponds to the webwork2 permission that ta's and above have). This is to address issue openwebwork#961.
somiaj
approved these changes
Nov 9, 2023
pstaabp
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new line to the beginning of the code for a macro file that starts with
=which will usually mean an invalid POD directive on the first line of the file (and is invalid in any case for the first character of a Perl file).In that case a warning is also shown. This warning will only be shown if the view_problem_debugging_info flag is set (this corresponds to the webwork2 permission that ta's and above have).
This is to address issue #961.