Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Tweaks #624

Merged
merged 2 commits into from
Sep 2, 2015
Merged

Editor Tweaks #624

merged 2 commits into from
Sep 2, 2015

Conversation

goehle
Copy link
Member

@goehle goehle commented Aug 27, 2015

This pull request does three things:

  • Added some checks to the Homework Sets Editor so that if you are in edit mode with insufficient permissions it doesn't spit out undefined variable errors.
  • To test go the homework sets as a ta and click the pencil. Before the patch you should get errors. Patch and then reload the page. There should be a nicer message.
  • Added checks so the pencil icons are not displayed unless you have permissions.
  • To test, go to Classlist Editor and Hmwrk Sets Editor as a professor, the pencils should be there. As a TA they should not.
  • Added a little tweak to math4 so that the side navigation bar won't be shown in a half formatted state.
  • This is hard to test. Go to the library browser and load up a bunch of problems. On some setups this will cause the left hand navigation bar to "half load" so that it is there but not formatted correctly. After this change the bar will be hidden until after its formatting js has run.

… page wont try to render if user doesn't have permissions

- removed pencil icons from ProblemSetList2 and UserList2 if user doesn't have permissions.
@mgage
Copy link
Sponsor Member

mgage commented Sep 2, 2015

Checked the pencil behavior -- that is ok now and since you can't get to the classlistEditor easily now as a TA the error message is moot.

I couldn't directly test the last tweak but I notice now that the left side bar does not render until after the library problems in the left half of the page. This can give the impression that the page is hung if there are a lot of library problems but there is a progress bar in most browsers that gives some visual indication that things are being processed.

mgage added a commit that referenced this pull request Sep 2, 2015
@mgage mgage merged commit 5364dd5 into openwebwork:develop Sep 2, 2015
@goehle goehle deleted the pencil branch September 2, 2015 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants