-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
can't add new youtube tracks #192
Comments
Thanks Tomer! Could be related to #190. But it's weird because automated tests passed... |
That's the behavior when pasting a YouTube URL in the search bar: That's the final error I'm getting, from the HTTP request to YouTube's API: {
error: {
errors: [
{
domain: "usageLimits",
reason: "dailyLimitExceeded",
message: "Daily Limit Exceeded. The quota will be reset at midnight Pacific Time (PT). You may monitor your quota usage and adjust limits in the API Console: https://console.developers.google.com/apis/api/youtube.googleapis.com/quotas?project=345430738996",
extendedHelp: "https://console.developers.google.com/apis/api/youtube.googleapis.com/quotas?project=345430738996"
}
],
code: 403,
message: "Daily Limit Exceeded. The quota will be reset at midnight Pacific Time (PT). You may monitor your quota usage and adjust limits in the API Console: https://console.developers.google.com/apis/api/youtube.googleapis.com/quotas?project=345430738996"
}
} Indeed, the API key I had created in #190 seems to have a quota of just 10k calls per day, which was reached quite quickly: |
Until I find a solution, I reverted back to our previous YouTube API key. This should work for now. |
## What does this PR do / solve? PlayemJS has been maintained for Openwhyd, to play and detect tracks, by communicating with the APIs of the streaming sources we support. While PlayemJS has supported more sources than most alternative players we have found online, its codebase has become hard to maintain, so it suffers from a lack of updates, which lead to numerous problems taking a lot of time and effort to fix: e.g. #272, #262, #192, #190, #143, #132, #128, #16... In order to simplify Openwhyd's codebase and make it easier for us to replace PlayemJS with an alternative, let's start by trying to remove it from the bookmarklet and see if anybody misses it from there.
## [1.43.1](v1.43.0...v1.43.1) (2020-11-28) ### Bug Fixes * **bookmaklet:** Transpile changes form [#408](#408) to JS ([59f6f98](59f6f98)) * **bookmarklet:** Re-add PlayemJS in bookmarklet ([#408](#408)), for track detection ([8fd1a3e](8fd1a3e)) * **bookmarklet:** Remove PlayemJS from bookmarklet ([#408](#408)) ([7296b21](7296b21)), closes [#272](#272) [#262](#262) [#192](#192) [#190](#190) [#143](#143) [#132](#132) [#128](#128) [#16](#16)
console shows
2/2 list streamable tracks... apis.google.com/…/rs=AGLTcCNo3EDgCfnM5…/cb=gapi.loaded_0:149 GET https://content.googleapis.com/youtube/v3/videos… 403 zu @ apis.google.com/…/rs=AGLTcCNo3EDgCfnM5…/cb=gapi.loaded_0:149 n @ apis.google.com/…/rs=AGLTcCNo3EDgCfnM5…/cb=gapi.loaded_0:149 Cu @ apis.google.com/…/rs=AGLTcCNo3EDgCfnM5…/cb=gapi.loaded_0:150 (anonymous) @ apis.google.com/…/rs=AGLTcCNo3EDgCfnM5…/cb=gapi.loaded_0:150 g @ apis.google.com/…/rs=AGLTcCNo3EDgCfnM5…/cb=gapi.loaded_0:126 c @ apis.google.com/…/rs=AGLTcCNo3EDgCfnM5…/cb=gapi.loaded_0:122 playem-min.js?1551713395824:2 Uncaught TypeError: Cannot read property 'map' of undefined at playem-min.js?1551713395824:2 at cb=gapi.loaded_0:694 at cb=gapi.loaded_0:689 at cb=gapi.loaded_0:678 at Object.<anonymous> (cb=gapi.loaded_0:198) at Object.E.__cb (cb=gapi.loaded_0:135) at g (cb=gapi.loaded_0:129) at c (cb=gapi.loaded_0:125)
The text was updated successfully, but these errors were encountered: