Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sideBox): inform about YouTube issues #272

Merged
merged 1 commit into from
Mar 1, 2020
Merged

feat(sideBox): inform about YouTube issues #272

merged 1 commit into from
Mar 1, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Mar 1, 2020 •
edited
Loading

Before:

Capture d’écran 2020-03-01 à 15 37 49

After:

Capture d’écran 2020-03-01 à 15 38 26

@adrienjoly adrienjoly self-assigned this Mar 1, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Mar 1, 2020
This was linked to issues Mar 1, 2020
"Add" button not working when trying to add a track #262
Closed
adding a track from youtube.com (using chrome extension) makes Openwhyd server crash #266
Closed
@adrienjoly adrienjoly merged commit 0341ea0 into master Mar 1, 2020
Development automation moved this from 📥 Inbox / ideas to ✔️ Done / pending QA Mar 1, 2020
@adrienjoly adrienjoly deleted the feat/inform-about-youtube-issues branch March 1, 2020 14:48
adrienjoly pushed a commit that referenced this pull request Mar 1, 2020
@semantic-release-bot
chore(release): 1.22.0 [skip ci]
5e5bdd8 
# [1.22.0](v1.21.4...v1.22.0) (2020-03-01)

### Features

* **sideBox:** inform about YouTube issues ([#272](#272)) ([0341ea0](0341ea0)), closes [#262](#262) [#266](#266)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Mar 1, 2020
@adrienjoly adrienjoly moved this from 🌲 In production to ✔️ Done / pending QA in Development Mar 13, 2020
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Mar 13, 2020
@adrienjoly adrienjoly mentioned this pull request Nov 28, 2020
Merged
adrienjoly added a commit that referenced this pull request Nov 28, 2020
@adrienjoly
fix(bookmarklet): Remove PlayemJS from bookmarklet (#408)
7296b21 
## What does this PR do / solve?

PlayemJS has been maintained for Openwhyd, to play and detect tracks, by communicating with the APIs of the streaming sources we support.

While PlayemJS has supported more sources than most alternative players we have found online, its codebase has become hard to maintain, so it suffers from a lack of updates, which lead to numerous problems taking a lot of time and effort to fix: e.g. #272, #262, #192, #190, #143, #132, #128, #16...

In order to simplify Openwhyd's codebase and make it easier for us to replace PlayemJS with an alternative, let's start by trying to remove it from the bookmarklet and see if anybody misses it from there.
adrienjoly pushed a commit that referenced this pull request Nov 28, 2020
@semantic-release-bot
chore(release): 1.43.1 [skip ci]
46a7fb1 
## [1.43.1](v1.43.0...v1.43.1) (2020-11-28)

### Bug Fixes

* **bookmaklet:** Transpile changes form [#408](#408) to JS ([59f6f98](59f6f98))
* **bookmarklet:** Re-add PlayemJS in bookmarklet ([#408](#408)), for track detection ([8fd1a3e](8fd1a3e))
* **bookmarklet:** Remove PlayemJS from bookmarklet ([#408](#408)) ([7296b21](7296b21)), closes [#272](#272) [#262](#262) [#192](#192) [#190](#190) [#143](#143) [#132](#132) [#128](#128) [#16](#16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
Development
  
🌲 In production
Milestone
No milestone
1 participant
@adrienjoly