[feature] Added ZeroTier backend #208 #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
3 times, most recently
from
15ae24e
to
c78e68b
Compare
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
4 times, most recently
from
9bf44af
to
b912d2e
Compare
nemesifier
reviewed
Jun 5, 2023
2 tasks
pandafy
requested changes
Jun 8, 2023
There was a problem hiding this comment.
Good progress @Aryamanz29! This PR is on the right track. 🚀
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
2 times, most recently
from
0f82d3f
to
b0a83a1
Compare
pandafy
reviewed
Jun 13, 2023
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
from
9211662
to
61b4cc6
Compare
nemesifier
reviewed
Jun 13, 2023
nemesifier
requested changes
Jun 14, 2023
There was a problem hiding this comment.
@Aryamanz29 please start adding a draft doc page for the zerotier backend with the most basic points (eg: the configuration format used is the JSON used by the API, initialization parameters, a basic example).
The schema is taken from OpenAPI specification: https://docs.zerotier.com/service/v1/ (self-hosted controllers) https://docs.zerotier.com/openapi/centralv1.json (central controllers) The Zerotier network configuration keys taken from: https://github.com/zerotier/ZeroTierOne/blob/dev/node/NetworkConfig.hpp
- Added propertyOrder to schema.
- Removed redundant OpenAPI schema property 'example'. - Changed backend render json indentation to 4 spaces.
- Added comment to `_generate_contents` method.
The ZeroTier parser should parse VPN configurations with and without comments
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
from
cf8555b
to
23f338f
Compare
nemesifier
approved these changes
Jun 16, 2023
This was referenced Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites:
Install Zerotier
Install Ztncui - Web Interface
Get your Zerotier Service API token
sudo cat /var/lib/zerotier-one/authtoken.secretTested with openwisp-controller
demo-zerotier.mp4
Todos
Closes #208