[feature] Added support for ZeroTier to the OpenWRT backend #207 #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema is taken from OpenAPI specification: https://docs.zerotier.com/service/v1/ (self-hosted controllers) https://docs.zerotier.com/openapi/centralv1.json (central controllers) The Zerotier network configuration keys taken from: https://github.com/zerotier/ZeroTierOne/blob/dev/node/NetworkConfig.hpp
- Added propertyOrder to schema.
- Used `None` as a default argument and assign the mutable value inside the method. - Removed redundant OpenAPI schema property 'example'. - Changed backend render json indentation to 4 spaces.
Aryamanz29
changed the title
The schema is taken from OpenAPI specification: https://docs.zerotier.com/service/v1/ (self-hosted controllers) https://docs.zerotier.com/openapi/centralv1.json (central controllers) The Zerotier network configuration keys taken from: https://github.com/zerotier/ZeroTierOne/blob/dev/node/NetworkConfig.hpp
- Added propertyOrder to schema.
- Removed redundant OpenAPI schema property 'example'. - Changed backend render json indentation to 4 spaces.
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
from
eefe53d
to
0f82d3f
Compare
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
from
0f82d3f
to
b0a83a1
Compare
…tier-to-openwrt-backend
Aryamanz29
force-pushed
the
issue-207/add-zerotier-to-openwrt-backend
branch
from
215acdb
to
21ea65e
Compare
pandafy
reviewed
Jun 13, 2023
Aryamanz29
force-pushed
the
issue-208/add-zerotier-backend
branch
from
cf8555b
to
23f338f
Compare
There are certain properties in the ZeroTier schema that require default values. For example, if we don't provide a default value for the `multicastLimit` property, it will be set to `0` during an API call, which disables IPv4 communication for the network. More information: https://docs.zerotier.com/zerotier/rules
nemesifier
reviewed
Jun 20, 2023
Other changes: - Used checkbox input for "boolean" schema properties.
Aryamanz29
force-pushed
the
issue-207/add-zerotier-to-openwrt-backend
branch
from
1c91d8e
to
9c9af75
Compare
Aryamanz29
force-pushed
the
issue-207/add-zerotier-to-openwrt-backend
branch
from
9c9af75
to
474d928
Compare
Aryamanz29
force-pushed
the
issue-207/add-zerotier-to-openwrt-backend
branch
from
0e9ec35
to
7c723c0
Compare
pandafy
requested changes
Jul 20, 2023
There was a problem hiding this comment.
Good work @Aryamanz29! It looks very close to getting merged.
- Clubbed the "Enabled Broadcast," "MRL" and "MTU" properties together.
Aryamanz29
force-pushed
the
issue-207/add-zerotier-to-openwrt-backend
branch
3 times, most recently
from
d61bb29
to
940a6db
Compare
Aryamanz29
force-pushed
the
issue-207/add-zerotier-to-openwrt-backend
branch
from
940a6db
to
d965e8e
Compare
nemesifier
reviewed
Jul 27, 2023
nemesifier
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
Prerequisites:
Install Zerotier
Install Ztncui - Web Interface
Get your Zerotier Service API token
sudo cat /var/lib/zerotier-one/authtoken.secretTested with openwisp-controller
demo-zerotier-openwrt.mp4
Closes #207