Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Use non-mutable default arguments #275

Merged
merged 1 commit into from Jun 8, 2023

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Jun 8, 2023

Fixed signature of netjsonconfig.backends.openvpn.converters.OpenVpn.__intermediate_vpn to use non-mutable default argument.

@coveralls
Copy link

coveralls commented Jun 8, 2023

Coverage Status

coverage: 98.728% (+0.4%) from 98.336% when pulling 0c1744b on fix-mutable-default-argument into 2e7d548 on master.

Fixed signature of netjsonconfig.backends.openvpn.converters.OpenVpn.__intermediate_vpn
to use non-mutable default argument.

Co-authored-by: Aryaman <aryamanz29@gmail.com>
@pandafy pandafy force-pushed the fix-mutable-default-argument branch from bcfce41 to 0c1744b Compare June 8, 2023 12:55
Copy link
Member

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@nemesifier nemesifier merged commit 96d811f into master Jun 8, 2023
6 checks passed
@nemesifier nemesifier deleted the fix-mutable-default-argument branch June 8, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants