Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Notifications: Cannot read property '0' of null #282

Closed
nemesifier opened this issue Sep 17, 2020 · 4 comments · Fixed by #309
Closed

[bug] Notifications: Cannot read property '0' of null #282

nemesifier opened this issue Sep 17, 2020 · 4 comments · Fixed by #309
Labels
bug
Projects
OpenWISP Priorities for next releases Roadmap

Comments

@nemesifier
Copy link
Member

How to replicate:

  • open add vpn server page
  • look at the JS console

Screenshot from 2020-09-17 13-30-57

Screenshot from 2020-09-17 13-31-28

@pandafy can you help out fix this?
@nemesifier nemesifier added the bug label Sep 17, 2020
@nemesifier nemesifier added this to To do in OpenWISP Priorities for next releases via automation Sep 17, 2020
@nemesifier nemesifier added this to To do general in Roadmap via automation Sep 17, 2020
@pniaps
Copy link
Member

pniaps commented Sep 17, 2020

It happends in all 'Add' pages, but not when editing a object.

@pandafy pandafy mentioned this issue Sep 18, 2020
Closed
@pandafy
Copy link
Member

pandafy commented Sep 18, 2020

@pniaps Thanks for investigating it further.

Earlier, I was under the presumption that Django uses a separate template for generating add_view. After looking into Django's code, I found out my assumption was wrong. Since, this problem lies in openwisp-notifications, I have created an issue and patch there. Using that patch, this error should not occur. I have tested it in both openwisp-controller and openwisp-monitoring.

@nemesifier
Copy link
Member Author

Cool, it's fixed in openwisp/openwisp-notifications#129, but I think we should leave this open until we release a new bugfix version of openwisp-notifications and update https://github.com/openwisp/openwisp-controller/blob/master/requirements.txt#L11 accordingly, I also think this should be removed: https://github.com/openwisp/openwisp-controller/blob/master/install-dev.sh#L4-L5 so we can take advantage and do these changes when closing this issue.

@nemesifier nemesifier mentioned this issue Oct 15, 2020
Closed
@nemesifier
Copy link
Member Author

Related to #308

@pandafy pandafy mentioned this issue Oct 18, 2020
Merged
pandafy added a commit to pandafy/openwisp-controller that referenced this issue Oct 18, 2020
@pandafy
[chores] Updated openwisp_notifications to 0.2 openwisp#308
0127702 
- Removed openwisp_notifications from `install-dev.sh`
  (openwisp_notification==0.2.1 is already released)
- Removed openwsip_users from `install-dev.sh`
  (openwisp_users==0.4.1 is already released)
- Added `rest` dependencies to openwisp_utils
Closes openwisp#308
Closes openwisp#282
OpenWISP Priorities for next releases automation moved this from To do to Done Oct 20, 2020
Roadmap automation moved this from To do general to Done Oct 20, 2020
nemesifier pushed a commit that referenced this issue Oct 20, 2020
@pandafy
[chores] Updated openwisp_notifications to 0.2 #308
488a40f 
- Removed openwisp_notifications from `install-dev.sh`
  (openwisp_notification==0.2.1 is already released)
- Removed openwsip_users from `install-dev.sh`
  (openwisp_users==0.4.1 is already released)
- Added `rest` dependencies to openwisp_utils

Closes #308
Closes #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
OpenWISP Priorities for next releases
  
Done
Roadmap
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chores] Updated openwisp_notifications to 0.2 #308 pandafy/openwisp-controller
3 participants
@nemesifier @pniaps @pandafy