Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[deps] Increase openwisp-notifications version to 0.2 #308

Closed
nemesifier opened this issue Oct 18, 2020 · 1 comment · Fixed by #309
Closed

[deps] Increase openwisp-notifications version to 0.2 #308

nemesifier opened this issue Oct 18, 2020 · 1 comment · Fixed by #309
Labels
enhancement
Projects
OpenWISP Contributor's Board

Comments

@nemesifier
Copy link
Member

nemesifier commented Oct 18, 2020 •
edited
Loading

@pandafy seems we have openwisp-notifications 0.1: https://github.com/openwisp/openwisp-controller/blob/master/requirements.txt#L11. Are settings changes needed to increase the version?
@nemesifier nemesifier added this to To do (general) in OpenWISP Contributor's Board via automation Oct 18, 2020
@nemesifier nemesifier mentioned this issue Oct 18, 2020
Closed
@pandafy
Copy link
Member

pandafy commented Oct 18, 2020

Are settings changes needed to increase the version?

I don't think we will need to add any changes since the build was installing openwisp_notification from the master branch of the repository. I will double check the changes just in case.

@pandafy pandafy mentioned this issue Oct 18, 2020
Merged
pandafy added a commit to pandafy/openwisp-controller that referenced this issue Oct 18, 2020
@pandafy
[chores] Updated openwisp_notifications to 0.2 openwisp#308
0127702 
- Removed openwisp_notifications from `install-dev.sh`
  (openwisp_notification==0.2.1 is already released)
- Removed openwsip_users from `install-dev.sh`
  (openwisp_users==0.4.1 is already released)
- Added `rest` dependencies to openwisp_utils
Closes openwisp#308
Closes openwisp#282
OpenWISP Contributor's Board automation moved this from To do (general) to Done Oct 20, 2020
nemesifier pushed a commit that referenced this issue Oct 20, 2020
@pandafy
[chores] Updated openwisp_notifications to 0.2 #308
488a40f 
- Removed openwisp_notifications from `install-dev.sh`
  (openwisp_notification==0.2.1 is already released)
- Removed openwsip_users from `install-dev.sh`
  (openwisp_users==0.4.1 is already released)
- Added `rest` dependencies to openwisp_utils

Closes #308
Closes #282
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
OpenWISP Contributor's Board
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[chores] Updated openwisp_notifications to 0.2 #308 pandafy/openwisp-controller
2 participants
@nemesifier @pandafy