Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chores] Updated openwisp_notifications to 0.2 #308 #309

Merged
merged 1 commit into from
Oct 20, 2020
Merged

[chores] Updated openwisp_notifications to 0.2 #308 #309

merged 1 commit into from
Oct 20, 2020

Conversation

pandafy
Copy link
Member

@pandafy pandafy commented Oct 18, 2020

  • Removed openwisp_notifications from install-dev.sh
    (openwisp_notification==0.2.1 is already released)
  • Removed openwsip_users from install-dev.sh
    (openwisp_users==0.4.1 is already released)

Closes #308
Closes #282

@TravisBuddy
Copy link

Travis tests have failed

Hey @pandafy,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

6th Build

View build log

./run-qa-checks 
SUCCESS: Blank endline check successful!
SUCCESS: Migration name check on "./openwisp_controller/config/migrations" with migrations-to-ignore: 12 successful!
SUCCESS: Migration name check on "./openwisp_controller/connection/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./openwisp_controller/geo/migrations" with migrations-to-ignore: 0 successful!
SUCCESS: Migration name check on "./openwisp_controller/pki/migrations" with migrations-to-ignore: 4 successful!
Skipped 1 files
SUCCESS: Isort check successful!
All done! ✨ 🍰 ✨
193 files would be left unchanged.
SUCCESS: Black check successful!
SUCCESS: Flake8 check successful!
SUCCESS: Commit message check successful!
Traceback (most recent call last):
  File "tests/manage.py", line 10, in <module>
    execute_from_command_line(sys.argv)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
    utility.execute()
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 395, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 330, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 368, in execute
    self.check()
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 396, in check
    databases=databases,
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/registry.py", line 70, in run_checks
    new_errors = check(app_configs=app_configs, databases=databases)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/urls.py", line 13, in check_url_config
    return check_resolver(resolver)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/urls.py", line 23, in check_resolver
    return check_method()
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 408, in check
    for pattern in self.url_patterns:
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 589, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 582, in urlconf_module
    return import_module(self.urlconf_name)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/travis/build/openwisp/openwisp-controller/tests/openwisp2/urls.py", line 37, in <module>
    url(r'', include('openwisp_notifications.urls')),
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/conf.py", line 34, in include
    urlconf_module = import_module(urlconf_module)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/urls.py", line 3, in <module>
    from .api.urls import get_api_urls
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/api/urls.py", line 3, in <module>
    from openwisp_notifications.api import views
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/api/views.py", line 4, in <module>
    from django_filters.rest_framework import DjangoFilterBackend
ModuleNotFoundError: No module named 'django_filters'
coverage run --source=openwisp_controller runtests.py 
Creating test database for alias 'default'...
Destroying test database for alias 'default'...
Traceback (most recent call last):
  File "runtests.py", line 20, in <module>
    execute_from_command_line(args)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
    utility.execute()
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 395, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/commands/test.py", line 23, in run_from_argv
    super().run_from_argv(argv)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 330, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 371, in execute
    output = self.handle(*args, **options)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/commands/test.py", line 53, in handle
    failures = test_runner.run_tests(test_labels)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/test/runner.py", line 698, in run_tests
    self.run_checks(databases)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/test/runner.py", line 636, in run_checks
    call_command('check', verbosity=self.verbosity, databases=databases)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 168, in call_command
    return command.execute(*args, **defaults)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 371, in execute
    output = self.handle(*args, **options)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/commands/check.py", line 69, in handle
    databases=options['databases'],
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 396, in check
    databases=databases,
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/registry.py", line 70, in run_checks
    new_errors = check(app_configs=app_configs, databases=databases)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/urls.py", line 40, in check_url_namespaces_unique
    all_namespaces = _load_all_namespaces(resolver)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/urls.py", line 57, in _load_all_namespaces
    url_patterns = getattr(resolver, 'url_patterns', [])
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 589, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 582, in urlconf_module
    return import_module(self.urlconf_name)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "tests/openwisp2/urls.py", line 37, in <module>
    url(r'', include('openwisp_notifications.urls')),
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/conf.py", line 34, in include
    urlconf_module = import_module(urlconf_module)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/urls.py", line 3, in <module>
    from .api.urls import get_api_urls
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/api/urls.py", line 3, in <module>
    from openwisp_notifications.api import views
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/api/views.py", line 4, in <module>
    from django_filters.rest_framework import DjangoFilterBackend
ModuleNotFoundError: No module named 'django_filters'
SAMPLE_APP=1 ./runtests.py --parallel --keepdb 
Using existing test database for alias 'default'...
Using existing clone for alias 'default'...
Using existing clone for alias 'default'...
Preserving test database for alias 'default'...
Preserving test database for alias 'default'...
Preserving test database for alias 'default'...
Traceback (most recent call last):
  File "./runtests.py", line 20, in <module>
    execute_from_command_line(args)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 401, in execute_from_command_line
    utility.execute()
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 395, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/commands/test.py", line 23, in run_from_argv
    super().run_from_argv(argv)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 330, in run_from_argv
    self.execute(*args, **cmd_options)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 371, in execute
    output = self.handle(*args, **options)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/commands/test.py", line 53, in handle
    failures = test_runner.run_tests(test_labels)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/test/runner.py", line 698, in run_tests
    self.run_checks(databases)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/test/runner.py", line 636, in run_checks
    call_command('check', verbosity=self.verbosity, databases=databases)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/__init__.py", line 168, in call_command
    return command.execute(*args, **defaults)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 371, in execute
    output = self.handle(*args, **options)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/commands/check.py", line 69, in handle
    databases=options['databases'],
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/management/base.py", line 396, in check
    databases=databases,
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/registry.py", line 70, in run_checks
    new_errors = check(app_configs=app_configs, databases=databases)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/urls.py", line 13, in check_url_config
    return check_resolver(resolver)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/core/checks/urls.py", line 23, in check_resolver
    return check_method()
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 408, in check
    for pattern in self.url_patterns:
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 589, in url_patterns
    patterns = getattr(self.urlconf_module, "urlpatterns", self.urlconf_module)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/utils/functional.py", line 48, in __get__
    res = instance.__dict__[self.name] = self.func(instance)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/resolvers.py", line 582, in urlconf_module
    return import_module(self.urlconf_name)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "tests/openwisp2/urls.py", line 37, in <module>
    url(r'', include('openwisp_notifications.urls')),
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/django/urls/conf.py", line 34, in include
    urlconf_module = import_module(urlconf_module)
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/urls.py", line 3, in <module>
    from .api.urls import get_api_urls
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/api/urls.py", line 3, in <module>
    from openwisp_notifications.api import views
  File "/home/travis/virtualenv/python3.7.6/lib/python3.7/site-packages/openwisp_notifications/api/views.py", line 4, in <module>
    from django_filters.rest_framework import DjangoFilterBackend
ModuleNotFoundError: No module named 'django_filters'
TravisBuddy Request Identifier: 49a63970-116d-11eb-bfd1-1f84b849c73d

@pandafy
[chores] Updated openwisp_notifications to 0.2 openwisp#308
0127702 
- Removed openwisp_notifications from `install-dev.sh`
  (openwisp_notification==0.2.1 is already released)
- Removed openwsip_users from `install-dev.sh`
  (openwisp_users==0.4.1 is already released)
- Added `rest` dependencies to openwisp_utils
Closes openwisp#308
Closes openwisp#282
@pandafy pandafy force-pushed the issues/308-notification-deps branch from eabe108 to 0127702 Compare October 18, 2020 18:41
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.293% when pulling 0127702 on pandafy:issues/308-notification-deps into 8f9f543 on openwisp:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.293% when pulling 0127702 on pandafy:issues/308-notification-deps into 8f9f543 on openwisp:master.

pandafy
pandafy commented Oct 18, 2020
View reviewed changes
requirements.txt
@@ -6,9 +6,9 @@ django-x509~=0.9.0
django-taggit~=1.3.0
django-loci>=0.3.1,<0.4.0
django-flat-json-widget~=0.1
openwisp-utils~=0.6.0
openwisp-utils[rest]~=0.6.0
Copy link
Member Author

@pandafy pandafy Oct 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nemesisdesign I had to add this change otherwise pip was not installing django-filters from openwisp_utils[rest]. I tried removing openwisp_utils altogether, thinking that it is already a dependency of openwisp_notification, but that didn't work either.

@nemesifier nemesifier merged commit 488a40f into openwisp:master Oct 20, 2020
@nemesifier
Copy link
Member

Thanks @pandafy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemesifier nemesifier nemesifier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[deps] Increase openwisp-notifications version to 0.2 [bug] Notifications: Cannot read property '0' of null
4 participants
@pandafy @TravisBuddy @coveralls @nemesifier