Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Unsubscribe button in device page is slightly higher than other buttons #573

Closed
nemesifier opened this issue Nov 24, 2021 · 12 comments
Labels
bug Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository.

Comments

@nemesifier
Copy link
Member

Screenshot from 2021-11-24 15-26-04

Can't be seen easily but if we focus our eyes on the lower part of the button we'll notice it's slightly higher than the other buttons, let's fix this.

@nemesifier nemesifier added the bug label Nov 24, 2021
@nemesifier nemesifier added the Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository. label Nov 24, 2021
@adityasangave
Copy link

Can I work on this?

@codesankalp
Copy link
Member

Can I work on this?

Yes, go ahead 👍

@subhamgcon
Copy link

Hey @codesankalp Is this issue still open or resolved?

@codesankalp
Copy link
Member

Hey @codesankalp Is this issue still open or resolved?

It's still open.

@rakite28
Copy link

rakite28 commented Jan 6, 2022

hey i am new to this i want to help resolve this can u give me some idea as to how i can move forward in this i have cloned the repo already and know a little bit about js

@codesankalp
Copy link
Member

hey i am new to this i want to help resolve this can u give me some idea as to how i can move forward in this i have cloned the repo already and know a little bit about js

@rakite28 explore and setup the repo first. when you will get familiar with this, you will be able to solve this.

@ashwini-m-hub
Copy link

its still open can I do

@codesankalp
Copy link
Member

@OsmiumOP You can start working without assigning if @ashwini-m-hub is not working on this. More issues are present here: https://github.com/orgs/openwisp/projects/4

@pandafy
Copy link
Member

pandafy commented Jan 25, 2022

Screenshot from 2022-01-25 19-13-36
Screenshot from 2022-01-25 19-13-22

Heights of unsubscribe and other buttons is different. It might be due to the notification bell icon.

@sahilsaini1107
Copy link

is this issue still open

@pandafy
Copy link
Member

pandafy commented Feb 17, 2022

@sahilsaini110 there's already a PR open for this.

@pandafy
Copy link
Member

pandafy commented Feb 17, 2022

This has been fixed in openwisp/openwisp-notifications#220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Good first issue Easy issue that new contributors may like to pick up to get themselves familiar with the repository.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

8 participants