Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

branches: add revision and mandatory to changes #404

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Oct 9, 2022

The revision can be used to "date" package changes so that updates between i.e. snapshots won't be suggested every time.

The mandatory field is used to specify if a changes is selectable or not. If a package is dropped, the changes will always be selected.

Signed-off-by: Paul Spooren paul.spooren@rhebo.com

The revision can be used to "date" package changes so that updates
between i.e. snapshots won't be suggested every time.

The mandatory field is used to specify if a changes is selectable or
not. If a package is dropped, the changes will always be selected.

Signed-off-by: Paul Spooren <paul.spooren@rhebo.com>
@codecov
Copy link

codecov bot commented Oct 9, 2022

Codecov Report

Base: 85.08% // Head: 85.08% // No change to project coverage 👍

Coverage data is based on head (15d86d9) compared to base (e5965b2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #404   +/-   ##
=======================================
  Coverage   85.08%   85.08%           
=======================================
  Files          13       13           
  Lines        1153     1153           
=======================================
  Hits          981      981           
  Misses        172      172           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aparcar aparcar merged commit 0c09512 into openwrt:master Oct 10, 2022
@aparcar aparcar deleted the package_changes_dict branch October 10, 2022 09:50
@dangowrt
Copy link
Member

If a package is dropped, the changes will always be selected.

A package which should be dropped optionally is also an imaginable situation, let's say e.g. in future we decide to ditch uclient-fetch in favor of yet another wget implenentation we would also drop libustream-wolfssl from the default package set. In that case, the package is dropped, but the user should have the option to keep it (as it is still present as a package in the tree, it's just no longer part of the default set and has been replaced there).

mandatory: true
- source: firewall
target: firewall4
revision: 18611
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As both changes (firewall -> firewall4, kmod-nft-nat6 -> null) are present already in the 22.03 release branch, why do you list them again in SNAPSHOT? That makes it much harder for the client to decide which changes to include...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants