Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: better handling of defaults #420

Merged
merged 1 commit into from
Nov 13, 2022
Merged

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Nov 13, 2022

If defaults are not allowed but the parameter is supplied, don't error out but instead just ignore it.

Always include the "defaults" content to the request hash, even if empty to avoid an extra case, adjust the corresponding hashes.

If defaults are set, remove the created package after an hour.

Signed-off-by: Paul Spooren mail@aparcar.org

If defaults are not allowed but the parameter is supplied, don't error
out but instead just ignore it.

Always include the "defaults" content to the request hash, even if
empty to avoid an extra case, adjust the corresponding hashes.

If defaults are set, remove the created package after an hour.

Signed-off-by: Paul Spooren <mail@aparcar.org>
@codecov
Copy link

codecov bot commented Nov 13, 2022

Codecov Report

Base: 84.71% // Head: 85.39% // Increases project coverage by +0.68% 🎉

Coverage data is based on head (8138f03) compared to base (bca0a03).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   84.71%   85.39%   +0.68%     
==========================================
  Files          13       13              
  Lines        1138     1150      +12     
==========================================
+ Hits          964      982      +18     
+ Misses        174      168       -6     
Impacted Files Coverage Δ
asu/api.py 71.89% <100.00%> (+0.85%) ⬆️
asu/common.py 92.72% <100.00%> (+1.34%) ⬆️
tests/test_api.py 100.00% <100.00%> (ø)
tests/test_common.py 100.00% <100.00%> (ø)
tests/test_stats.py 100.00% <100.00%> (ø)
asu/build.py 79.50% <0.00%> (+2.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aparcar aparcar merged commit ca77d1f into openwrt:master Nov 13, 2022
@aparcar aparcar deleted the better-defaults branch November 13, 2022 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant