Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: allow to prefix packages with a + #460

Merged
merged 1 commit into from
Apr 16, 2023
Merged

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Feb 18, 2023

When adding a + to the beginning of a package name it will modify the order of packages and thereby fix dependency issues of OPKG.

This is more of a advanced user feature.

@aparcar
Copy link
Member Author

aparcar commented Feb 18, 2023

@dangowrt thoughts?

@dangowrt
Copy link
Member

Sounds like a viable workaround to the problems with opkg. Of course, it would be better to not even need this kind of hacks in first place, but I also don't see anything problematic about this specific solution.

@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (9405e62) 85.32% compared to head (23161a3) 85.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   85.32%   85.40%   +0.07%     
==========================================
  Files          13       13              
  Lines        1152     1158       +6     
==========================================
+ Hits          983      989       +6     
  Misses        169      169              
Impacted Files Coverage Δ
asu/api.py 71.89% <100.00%> (ø)
asu/common.py 92.98% <100.00%> (+0.25%) ⬆️
tests/test_common.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

When adding a + to the beginning of a package name it will modify the
order of packages and thereby fix dependency issues of OPKG.

This is more of a advanced user feature.

Signed-off-by: Paul Spooren <mail@aparcar.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants