Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo where there should be a set and not a list in request packages #488

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

aparcar
Copy link
Member

@aparcar aparcar commented Apr 20, 2023

No description provided.

Signed-off-by: Paul Spooren <mail@aparcar.org>
Reported-by: Tianling Shen <cnsztl@immortalwrt.org>
Signed-off-by: Paul Spooren <mail@aparcar.org>
@aparcar
Copy link
Member Author

aparcar commented Apr 20, 2023

@1715173329 could you please have a look?

@1715173329
Copy link
Member

I can confirm it fixed my issue, thank you!

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.20 🎉

Comparison is base (c09f4fa) 85.40% compared to head (152a9cc) 85.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #488      +/-   ##
==========================================
+ Coverage   85.40%   85.61%   +0.20%     
==========================================
  Files          13       13              
  Lines        1158     1161       +3     
==========================================
+ Hits          989      994       +5     
+ Misses        169      167       -2     
Impacted Files Coverage Δ
asu/api.py 71.89% <100.00%> (ø)
tests/test_api.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aparcar aparcar merged commit 6a995b6 into openwrt:main Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants