Multiple fixes to make Podman work and simplify the setup #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially I thought it'd be smart to have both separated, however there was never a real reason why. Merge both into PUBLIC_PATH. Signed-off-by: Paul Spooren <mail@aparcar.org>
Signed-off-by: Paul Spooren <mail@aparcar.org>
Signed-off-by: Paul Spooren <mail@aparcar.org>
While at it, cleanup older releases Signed-off-by: Paul Spooren <mail@aparcar.org>
The default path is different on most machines and I didn't find a reliable way yet to set it automatically. User need to set `CONTAINER_HOST` to make things work. Signed-off-by: Paul Spooren <mail@aparcar.org>
Signed-off-by: Paul Spooren <mail@aparcar.org>
This surprisingly never came up since most profiles are different from one another, however this would cause issues where multiple target use i.e. "generic" as profile. Signed-off-by: Paul Spooren <mail@aparcar.org>
Instead of exporting anything, you may just run `flask run` Signed-off-by: Paul Spooren <mail@aparcar.org>
Previously it was REDIS_CONN which would store the actual connection, now just store the connection string. Signed-off-by: Paul Spooren <mail@aparcar.org>
By setting `CONTAINER_SOCK` prior to running `podman-compose up` the socket path is passed into the worker container and `CONTAINER_HOST` is automatically set. The workers then use `podman` to build images instead of running it *bare metal*. One should set `PUBLIC_PATH`, too, which points to the place where to store images and json files. Signed-off-by: Paul Spooren <mail@aparcar.org>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
+ Coverage 86.53% 86.69% +0.15%
==========================================
Files 13 13
Lines 936 932 -4
==========================================
- Hits 810 808 -2
+ Misses 126 124 -2
☔ View full report in Codecov by Sentry. |
A webserver should be deployed outside the rootless docker compose file. For testing files are server via Python anyway. Signed-off-by: Paul Spooren <mail@aparcar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR touches multiples areas, at its core it should make running an instance easier. Let's see how it goes.