Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shairport-sync: important bug fix and enhancements #1869

Closed
wants to merge 4 commits into from
Closed

shairport-sync: important bug fix and enhancements #1869

wants to merge 4 commits into from

Conversation

mikebrady
Copy link
Contributor

Shairport Sync 2.6 brings an important bug fix and some enhancements:

  1. A long-standing bug has been fixed which should make Shairport Sync more reliable and also compatible with Synology devices.
  2. Shairport Sync now sets latencies automatically, like it always should have, making it easier to integrate with, for example, audio|acacia and Synology devices.
  3. An extra setting allows you to use just part of the full level-control range of the mixer -- useful with the built-in DAC of the Raspberry Pi.

Signed-off-by: Mike Brady mikebrady@eircom.net

@mikebrady
Copy link
Contributor Author

Thanks @Noltari!

@sbyx
Copy link
Member

sbyx commented Oct 22, 2015

In general, please follow our guidelines, notably:

  1. Add Signed-Off-By to your commit descriptions (not the PR) so they end up in the git history.
  2. Prepend the commit-name with the packages they affect, so it is easier to distinguish which packages are affected by a commit.

…g and fix an important bug.

Signed-off-by: Mike Brady <mikebrady@eircom.net>
@mikebrady
Copy link
Contributor Author

Thanks for your comments, and apologies for not reading the contribution guidelines properly. Would my recent updates do the trick?

Regards
Mike

@Noltari Noltari closed this in dcb74ef Oct 24, 2015
@Noltari
Copy link
Member

Noltari commented Oct 24, 2015

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants