Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softethervpn5: Update libraries to fix 22.03 branch kernel incompatibility #20850

Closed
wants to merge 1 commit into from
Closed

Conversation

tew42
Copy link
Contributor

@tew42 tew42 commented Apr 20, 2023

Maintainer: ???
Compile tested: compiled for ath79 - Archer a7 v5 - OpenWRT 22.03.4 using the SDK in an Ubuntu 22.04 WSL environment
Run tested: ath79 - Archer a7 v5 - OpenWRT 22.03.4

Description:
As reported in #20807 the softethervpn5 libraries seem to have issues with keeping an open connection in 22.03 series builds, breaking module functionality. The root cause is not clear to me, though I'm guessing it's related to the newer kernel over 21.x. Regardless, building the package & libraries from a more recent upstream source code solved the issue.

Note 1: Seems like simple file editing on the website is insufficient for this commit, so re-started the whole thing with a proper git environment... Maybe now this will go better than my first attempts - sorry for the multiple requests.

Note 2: This patch should also be considered for master branch, but I can't really test on snapshot builds right now.

5.02.5180 appears to have issues with 22.03 builds, thus implemented upgrade by changing to recent git source for upstream code, and updating patches to account for this change.

Signed-off-by: Thomas Winkler <2049715+tew42@users.noreply.github.com>
@tew42
Copy link
Contributor Author

tew42 commented May 2, 2023

I'd appreciate any suggestions on how to properly get this to build, if it's even possible in this branch.

The core issue:

22.03 toolchain LibreSSL is missing required functions for softethervpn5 host compile. The requisite functions are of present in libopenssl - but that only helps for the target compilation part, not host.

Considered solutions:

  1. I forced the compile for my own machine by eliminating the offending function check in the host compile -- and it works just fine for me. But that is really not ideal, and may break some package functionality for other use cases than my own.

  2. Implement an openssl/host compilation in libopenssl Makefile. Probably the cleanest fix, but may create more problems than it solves beyond this specific case? Also perhaps overkill since the compile issue is solved in master/snapshot toolchain (newer LibreSSL).

  3. A "dirty" solution I've considered would copy/paste the relevant libraries from $target/usr into /hostpkg, or alternatively mess around with CFLAGS/LDFLAGS. But I'm assuming that this would create some issues with cross-platform builds or something? (first time I'm dealing with something like this)

  4. Leave the package "broken" in 22.03 branch, and implement the underlying version upgrade only in master/snapshot/23.xx, since the SSL dependency issue goes away there.

  5. ???

@tew42
Copy link
Contributor Author

tew42 commented Oct 17, 2023

Closed in favor of 23.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant