[23.05] irqbalance: Fix log spam and correct meson version #22851
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Irqbalance 1.9.3 changed the handling of certain errors. Specifically EINVAL, trying to set an invalid CPU core, was changed to be a temporary error, causing log spam from repeated balancing runs in some devices. See log and strace below. Mark EINVAL as permanent.
This errors seems to surface on 23.05 only on some devices, but not all.
And when I briefly tested, the unpatched 1.9.3 seemed to work in R7800 main/master build (with kernel 6.1) but fail with 23.05. So I initially author this fix just for 23.05
Also correct the version in our own meson.build patch.
Log and strace:
Maintainer: me
Run tested: ipq806x/R7800
I wrote a comment upstream. Interesting to see their views.
Irqbalance/irqbalance#269 (comment)