[DRAFT] collectd: minor dsl lua script changes #23011
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Aldrian <aldrian.thom@proton.me>
Signed-off-by: Thomas Aldrian <aldrian.thom@proton.me>
bluebrother
reviewed
Jan 1, 2024
| local metric = build_metric(name, direction) | ||
| if information["type"] == "bool" then | ||
|
|
||
| if name = type then |
There was a problem hiding this comment.
Is this intended to be an assignment? Looks like it should be == to me.
Also, I'm not a fan of this special case. I don't see much benefit but unnecessary extra complexity, but that might be just me :)
There was a problem hiding this comment.
Yup, you're right. That's just a typo. As I said, I haven't yet tested these changes lol.
You're probably right. I mean, it doesn't really make any difference so it could also just be a waste of time to put any more thought into it. Ultimately, it ain't my call. If you want this change removed, I'll happily do so.
Signed-off-by: Thomas Aldrian <aldrian.thom@proton.me>
systemcrash
approved these changes
Feb 3, 2024
|
If you think these look good - mark this as ready |
|
@Weissnix4711: Have you progressed on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: me / @<github-user> (find it by checking history of the package Makefile)
Compile tested: (put here arch, model, OpenWrt version)
Run tested: (put here arch, model, OpenWrt version, tests done)
Description:
rx_corrected,rx_uncorrected_protected,crc_pandcrcp_perrorsIf name and type are identical (currently only relevant for snr), the name will be ignored. Ie.snr-snr_downbecomessnr-down. I think this looks neater, but maybe that's just me.Open to criticism.
Primarily for openwrt/luci#6798