-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nginx: QUIC: Fix SSL 3.0 deprecated function #24005
Conversation
@qosmio did we check if nginx already doesn't have this fix in some dev branch? Also can we think of proposing this fix to nginx mailing list? |
That's actually a good idea. I haven't submitted patches upstream, mostly due to NGINX team using Mercurial and patchbomb, neither of which I'm too familiar. I'll take a stab at it though. |
@qosmio keep me informed... i also remember sending a patch but i lost track of it. |
@qosmio I checked how to send patch and it's not that hard...
Send the mail to yourself first to make sure everything is OK. |
9ec1a42
to
2908532
Compare
`EVP_CIPHER_CTX_cipher()` function was deprecated in OpenSSL 3.0. As per OpenSSL's recommendation (https://www.openssl.org/docs/manmaster/man3/EVP_CIPHER_CTX_get0_cipher.html) switch to using `EVP_CIPHER_CTX_get0_cipher()` instead. With this change and recent commit to nginx-util openwrt#23935. We should now be able to build nginx + modules with fully compliant calls to OpenSSL 3.0+ with legacy features disabled. Signed-off-by: Sean Khan <datapronix@protonmail.com> Link: openwrt#24005 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
@qosmio can you refresh patch and also bump the nginx package? |
Sorry I didn't get a chance to reply before. Will clean up and increment the build today.
UPDATE: Done!
|
2908532
to
3008de1
Compare
`EVP_CIPHER_CTX_cipher()` function was deprecated in OpenSSL 3.0. As per OpenSSL's recommendation (https://www.openssl.org/docs/manmaster/man3/EVP_CIPHER_CTX_get0_cipher.html) switch to using `EVP_CIPHER_CTX_get0_cipher()` instead. With this change and recent commit to nginx-util openwrt#23935. We should now be able to build nginx + modules with fully compliant calls to OpenSSL 3.0+ with legacy features disabled. Signed-off-by: Sean Khan <datapronix@protonmail.com> Link: openwrt#24005 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
3008de1
to
97082f1
Compare
`EVP_CIPHER_CTX_cipher()` function was deprecated in OpenSSL 3.0. As per OpenSSL's recommendation (https://www.openssl.org/docs/manmaster/man3/EVP_CIPHER_CTX_get0_cipher.html) switch to using `EVP_CIPHER_CTX_get0_cipher()` instead. With this change and recent commit to nginx-util #23935. We should now be able to build nginx + modules with fully compliant calls to OpenSSL 3.0+ with legacy features disabled. Signed-off-by: Sean Khan <datapronix@protonmail.com> Link: openwrt/packages#24005 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com> (cherry picked from commit 97082f12a6de70625e21bc22fe2d0c1f65797f52)
EVP_CIPHER_CTX_cipher()
function was deprecated in OpenSSL 3.0. As per OpenSSL's recommendation (https://www.openssl.org/docs/manmaster/man3/EVP_CIPHER_CTX_get0_cipher.html) switch to usingEVP_CIPHER_CTX_get0_cipher()
instead.This would remedy the following:
With this change and recent commit to nginx-util #23935. We should now be able to build
nginx
+modules
with fully compliant calls to OpenSSL 3.0+, with legacy features disabled.Run tested: aarch64, Dynalink DL-WRX36, Master Branch
Maintainer: Thomas Heil heil@terminal-consulting.de, Christian Marangi ansuelsmth@gmail.com