Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nft-qos remove unnecessary log to avoid log spam #24202

Closed
wants to merge 3 commits into from

Conversation

Mosney
Copy link

@Mosney Mosney commented May 22, 2024

Maintainer: @neheb @wulfy23 @champtar @lzto @ldir-EDB0 @rosysong

Compile tested: I think it’s don’t needed.

Run tested:

I comment out this logger line in 2 files at /etc/hotplug.d/dhcp/ on my OpenWrt, and it’s works normally.

Description:

Log DHCP info to system log is obviously unnecessary. I found some users in community also complaining about this because sometimes it leads to log spam.
See: https://www.right.com.cn/forum/thread-4091545-1-1.html

Signed-off-by: Mosney <Mosney@users.noreply.github.com>
Signed-off-by: Mosney <Mosney@users.noreply.github.com>
@Mosney
Copy link
Author

Mosney commented May 22, 2024

Log samples


Wed May 22 01:30:13 2024 user.notice nft-qos-monitor: ACTION=remove, MACADDR=MACADDR_1, IPADDR=IPADDR_1, HOSTNAME=HOSTNAME_1
Wed May 22 01:30:13 2024 user.notice nft-qos-dynamic: ACTION=remove, MACADDR=MACADDR_1, IPADDR=IPADDR_1, HOSTNAME=HOSTNAME_1
Wed May 22 02:36:56 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 02:36:56 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 02:43:32 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 02:43:32 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 05:00:02 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:00:02 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:00:03 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:00:03 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_3, IPADDR=IPADDR_3, HOSTNAME=HOSTNAME_3
Wed May 22 05:05:23 2024 user.notice nft-qos-monitor: ACTION=remove, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 05:05:23 2024 user.notice nft-qos-dynamic: ACTION=remove, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 08:30:32 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 08:30:32 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 08:43:32 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 08:43:33 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 10:14:54 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 10:14:54 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_2, IPADDR=IPADDR_2, HOSTNAME=HOSTNAME_2
Wed May 22 10:17:59 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 10:18:00 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 10:53:22 2024 user.notice nft-qos-monitor: ACTION=add, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 10:53:22 2024 user.notice nft-qos-dynamic: ACTION=add, MACADDR=MACADDR_4, IPADDR=IPADDR_4, HOSTNAME=HOSTNAME_4
Wed May 22 12:36:46 2024 user.notice nft-qos-monitor: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5
Wed May 22 12:36:47 2024 user.notice nft-qos-dynamic: ACTION=update, MACADDR=MACADDR_5, IPADDR=IPADDR_5, HOSTNAME=HOSTNAME_5

Signed-off-by: Mosney <Mosney@users.noreply.github.com>
@Mosney Mosney closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant