Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcoap: add coap client and server packages and update libcoap to 1.4.2 #4832

Merged
merged 2 commits into from
Sep 21, 2017

Conversation

dedeckeh
Copy link
Contributor

@dedeckeh dedeckeh commented Sep 14, 2017

Signed-off-by: Hans Dedecker dedeckeh@gmail.com

Maintainer: @toxxin
Compile tested: Atheros ARxx, TPLink WDR4300, LEDE trunk
Run tested: Atheros ARxx, TPLink WDR4300, LEDE trunk

Description:
Client package adds the CoAP client allowing to communicate with 6LoWPAN
devices via the CoAP protocol.
Server package adds the CoAP server and the CoAP Resource Directory server.
The CoAP server allows to simulate 6LoWPAN devices which can be addressed
via the CoAP protocol while the CoAP Resource Directory server can handle
resource registrations using the CoAP protocol.
Update libcoap to latest stable version 1.4.2

Client package adds the CoAP client allowing to communicate with 6LoWPAN
devices via the CoAP protocol.
Server package adss the CoAP server and the CoAP Resource Directory server.
The CoAP server allows to simulate 6LoWPAN devices which can be addressed
via the CoAP protocol while the CoAP Resource Directory server can handle
resource registrations using the CoAP protocol.

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
@diizzyy
Copy link
Contributor

diizzyy commented Sep 15, 2017

Please bump it to a newer checkout and change it to xz instead of bz2.

@toxxin
Copy link
Contributor

toxxin commented Sep 15, 2017

Do we really need to add server/client examples to the main branch?

@dedeckeh
Copy link
Contributor Author

dedeckeh commented Sep 15, 2017

@toxxin I'm using the coap client to transfer data collected on an embedded device to a remote web server. The client implementation fits the needs both feature and memory wise on an embedded device.
For completeness I added a separate coap server package allowing to enable the coap server programs which is usefull for testing purposes

@toxxin
Copy link
Contributor

toxxin commented Sep 15, 2017

Actually I don't know. I'm not a big fan to include examples and other binaries, because this is the library package. Maybe it's ok. @diizzyy what do you think?

@karlp
Copy link
Contributor

karlp commented Sep 15, 2017

LGTM 👍 version bumps and packaging changes are out of scope and should be separate contained self contained commits.

@toxxin You still get the libcoap (library only) package. This just uses the same source to add the client/server packages as options.

@diizzyy
Copy link
Contributor

diizzyy commented Sep 15, 2017

I'm not sure I follow but examples are needed to build client/server?

@dedeckeh
Copy link
Contributor Author

@diizzyy Correct examples are needed to build the client/server utilities. Meanwhile I've a patch in my packages repo which updates libcoap to 4.1.2 (dedeckeh@b7e3196)

@dedeckeh dedeckeh changed the title libcoap: add coap client and server packages libcoap: add coap client and server packages and update libcoap to v1.4.2 Sep 18, 2017
Update libcoap to latest stable version 4.1.2
While at it switch from tar extension bz2 to xz

Signed-off-by: Hans Dedecker <dedeckeh@gmail.com>
@dedeckeh
Copy link
Contributor Author

@diizzyy @karlp Any further comments on the PR ?

@diizzyy
Copy link
Contributor

diizzyy commented Sep 19, 2017

@dedeckeh
LGTM

I would expect this to blow up on the buildbots during next update however....
https://github.com/obgm/libcoap/blob/91663e9510e56c49d4b7ff72777822e614eb1601/configure.ac#L258

Also, cosmetic but the topic of the pull req is wrong (version)

@dedeckeh dedeckeh changed the title libcoap: add coap client and server packages and update libcoap to v1.4.2 libcoap: add coap client and server packages and update libcoap to 1.4.2 Sep 19, 2017
@dedeckeh
Copy link
Contributor Author

@hnyman Can you merge this PR ?

@hnyman hnyman merged commit e2513af into openwrt:master Sep 21, 2017
@dedeckeh dedeckeh deleted the pr-coap branch December 22, 2017 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants