Link frontend contract tickets in the spec #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have clearly identified the deltas between how the StableHLO dialect is used by frontends and what is specced (see https://github.com/orgs/openxla/projects/6), I figured it would be good to link these deltas in the spec, so that it's clear what areas are expected to change in the near future.
|
LGTM otherwise. |
sdasgup3
approved these changes
Feb 7, 2023
|
Thank you for the thorough review! To address the comment about #606 and #714, indeed I haven't included them in the PR because I didn't find a great way to call them out. #606 is more of a double-check rather than something that I think will lead to change, and #714 is a particular case of the matter of associativity of reducers, so I figured it'd be fine to not mention them. |
GleasonK
pushed a commit
to GleasonK/stablehlo
that referenced
this pull request
Feb 10, 2023
Now that we have clearly identified the deltas between how the StableHLO dialect is used by frontends and what is specced (see https://github.com/orgs/openxla/projects/6), I figured it would be good to link these deltas in the spec, so that it's clear what areas are expected to change in the near future. As I was working on this pull request, I also called out several tickets which are not part of the Frontend Contract project, because they represented highly likely todos from the New Features project. I think this is also useful to include in the spec for the readers to understand the anticipated direction of StableHLO evolution.
atondwal
pushed a commit
to atondwal/stablehlo
that referenced
this pull request
Mar 3, 2023
Now that we have clearly identified the deltas between how the StableHLO dialect is used by frontends and what is specced (see https://github.com/orgs/openxla/projects/6), I figured it would be good to link these deltas in the spec, so that it's clear what areas are expected to change in the near future. As I was working on this pull request, I also called out several tickets which are not part of the Frontend Contract project, because they represented highly likely todos from the New Features project. I think this is also useful to include in the spec for the readers to understand the anticipated direction of StableHLO evolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have clearly identified the deltas between how the StableHLO dialect is used by frontends and what is specced (see https://github.com/orgs/openxla/projects/6), I figured it would be good to link these deltas in the spec, so that it's clear what areas are expected to change in the near future.
As I was working on this pull request, I also called out several tickets which are not part of the Frontend Contract project, because they represented highly likely todos from the New Features project. I think this is also useful to include in the spec for the readers to understand the anticipated direction of StableHLO evolution.