[ROCm] fixed gcc build #14295
Closed
[ROCm] fixed gcc build #14295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezhulenev
reviewed
Jun 28, 2024
| @@ -360,12 +360,16 @@ class LiteralBase { | |||
| // function which would lead to inconsistencies. Use Hash instead. | |||
| template <typename H> | |||
| friend H AbslHashValue(H state, const LiteralBase& value) { | |||
| #if (!defined(__GNUC__)) // clang | |||
| static_assert(false, | |||
There was a problem hiding this comment.
can you instead of disabling this check for gcc change it to static_assert(sizeof(H) == 0, ... (see https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2593r0.html)
There was a problem hiding this comment.
thanks for this link! looks :)static_assert(always_false<T>::value); is a more acceptable way...
|
thanks @ezhulenev for the suggestion! PTAL |
|
This can be closed due to #14296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc compilation will break due to this change 4d7ec1e
@xla-rotation