[ROCm] Use unique_ptr for TupleHandle in pjrt_se_client #17430
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsharsha
force-pushed
the
ci_use_shared_ptr_20240920
branch
from
c7515c2
to
5e34ba4
Compare
klucke
suggested changes
Sep 30, 2024
hsharsha
force-pushed
the
ci_use_shared_ptr_20240920
branch
from
5e34ba4
to
681c285
Compare
klucke
approved these changes
Sep 30, 2024
hsharsha
changed the title
On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same
hsharsha
force-pushed
the
ci_use_shared_ptr_20240920
branch
from
681c285
to
80eb830
Compare
klucke
approved these changes
Sep 30, 2024
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Imported from GitHub PR #17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb830 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17430 from ROCm:ci_use_shared_ptr_20240920 80eb830 PiperOrigin-RevId: 680653976
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 1, 2024
Imported from GitHub PR openxla/xla#17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 680653976
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Imported from GitHub PR #17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb830 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17430 from ROCm:ci_use_shared_ptr_20240920 80eb830 PiperOrigin-RevId: 680653976
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 1, 2024
Imported from GitHub PR openxla/xla#17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 680653976
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Imported from GitHub PR #17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb830 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17430 from ROCm:ci_use_shared_ptr_20240920 80eb830 PiperOrigin-RevId: 680653976
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 1, 2024
Imported from GitHub PR openxla/xla#17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 680653976
copybara-service bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
Imported from GitHub PR #17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb830 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=#17430 from ROCm:ci_use_shared_ptr_20240920 80eb830 PiperOrigin-RevId: 680653976
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
Imported from GitHub PR openxla/xla#17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 680653976
Merged
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
…tion. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 681513593
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
…cutor wrappers. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 681510067
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
…e of `shard_map`. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 677110682
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 680652154
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
…than strategies). FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 681254097
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
…e of `shard_map`. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 677110682
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
…erOutput> as the AutoShardingSolverResult::skip_auto_sharding is now dead after some recent changes. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 678928364
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
Now that Shardy will now be fully integrated, we should delete the `ShardyCallInliner` and update `CallInliner` to look for what `ShardyCallInliner` checks for. We've had two bugs because of this thus far. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 679653544
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
…erOutput> as the AutoShardingSolverResult::skip_auto_sharding is now dead after some recent changes. FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 678928364
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
Imported from GitHub PR openxla/xla#17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 PiperOrigin-RevId: 681556381
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 2, 2024
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17430 from ROCm:ci_use_shared_ptr_20240920 80eb83068d89982a743a69f83af9f351d6a829d6 PiperOrigin-RevId: 680652154
tensorflow-jenkins
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Oct 10, 2024
Imported from GitHub PR openxla/xla#17430 On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Copybara import of the project: -- 80eb83068d89982a743a69f83af9f351d6a829d6 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Use unique_ptr for TupleHandle in pjrt_se_client On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same Merging this change closes #17430 PiperOrigin-RevId: 681556381
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older gcc (specifically in Ubuntu-20.04) and absl copy operator fails to copy created TupleHandle into an existing variable. Instead use unique_ptr to accompalish the same