Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Extract common builder code into hlo_creation_utils #17754

Closed
wants to merge 1 commit into from
Closed

[NFC] Extract common builder code into hlo_creation_utils #17754

wants to merge 1 commit into from

Conversation

sergey-kozub
Copy link
Contributor

Added XlaComputationToHloComputation helper function to hlo_creation_utils and replace the uses.

copybara-service bot pushed a commit that referenced this pull request Oct 1, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
ab61e0a 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
@copybara-service copybara-service bot mentioned this pull request Oct 1, 2024
Closed
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 1, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
a9dc1fd 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
@copybara-service copybara-service bot mentioned this pull request Oct 1, 2024
Merged
copybara-service bot pushed a commit that referenced this pull request Oct 1, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
2535704 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 1, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
ab9deb3 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 1, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
59f5e53 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
@sergey-kozub
Copy link
Contributor Author

Which copybara checks have failed? Is this something I can fix in OSS?

@akuegel
Copy link
Member

akuegel commented Oct 2, 2024

Which copybara checks have failed? Is this something I can fix in OSS?

It is a compile error due to missing dependency, see my other comment.

copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
14149bc 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 2, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
3f10091 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
543a38e 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
b809266 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
26c0b37 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 2, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
a345619 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
713f36b 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 2, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
73bd780 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
5b5e9fd 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 2, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
b881f95 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
fd6af93 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 2, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
6eedcd2 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 2, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
e5fabeb 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 63cbc86
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 2, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
915d212 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
63cbc86d3d355b9c0e1d19a31d59859a62d55328 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder 63cbc86d3d355b9c0e1d19a31d59859a62d55328
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
4eaa419 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
26a65b6 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 26a65b6
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
b14dc7b 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
26a65b6 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 26a65b6
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
c4ace91 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
26a65b6 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 26a65b6
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
46c9654 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
26a65b6 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder 26a65b6
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
b2eed26 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
8e5831d 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
a0844a4 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
f2043e2 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
6638ae4 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
7a64f0e 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 4, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
3aab309 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 7, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
562c2d9 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 7, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
ffa643e 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2cee78f6160eab9436121d4dfa2c89d168 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder f9cbfd2cee78f6160eab9436121d4dfa2c89d168
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 7, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
bd4ab19 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 7, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
5fec7f7 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2cee78f6160eab9436121d4dfa2c89d168 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder f9cbfd2cee78f6160eab9436121d4dfa2c89d168
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 7, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
0cc7f1c 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 7, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
2bd9ecf 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2cee78f6160eab9436121d4dfa2c89d168 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder f9cbfd2cee78f6160eab9436121d4dfa2c89d168
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 7, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
a78fbfe 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 7, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
74a4f2d 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2cee78f6160eab9436121d4dfa2c89d168 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder f9cbfd2cee78f6160eab9436121d4dfa2c89d168
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit that referenced this pull request Oct 7, 2024
@sergey-kozub @Google-ML-Automation
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
d774a54 
Imported from GitHub PR #17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17754 from openxla:skozub/xla_builder f9cbfd2
PiperOrigin-RevId: 680912058
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 7, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
6e96555 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2cee78f6160eab9436121d4dfa2c89d168 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder f9cbfd2cee78f6160eab9436121d4dfa2c89d168
PiperOrigin-RevId: 680912058
@copybara-service copybara-service bot closed this in 04cee7e Oct 7, 2024
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 7, 2024
@mooskagh @tensorflower-gardener
[XLA] Refactor LayoutMode / MemorySpaceColor handling to avoid code d…
f90a837 
…uplication.

This is a pure refactoring, and doesn't intend to change any behavior.

It is done in preparation to change how AUTO LayoutMode is encoded in HLO (not StableHLO/MLIR).
- Original idea was that HLO would have frontend attributes that mirror StableHLO layout attributes, but actually those frontend attributes are never populated, and there is only one place in the code that read them.
- All other paths (e.g. PjRT) don't support AUTO layout and always reset it to the default.

The plan (in the follow up change) is to:
- Introduce two "new" ways to fetch layout mode from the HLO:
    * "unset layout means default" -- that the current behavior in most APIs.
    * "unset layout means auto" -- this is the current behavior inside XLA.
- In PjRT (and potentially other APIs), change "unset means default" to "unset means auto", likely behind the flag.
- Likely remove the remaining piece of code that reads frontend attributes to determine the layout mode.

FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#17754 from openxla:skozub/xla_builder f9cbfd2cee78f6160eab9436121d4dfa2c89d168
PiperOrigin-RevId: 682642997
@copybara-service copybara-service bot mentioned this pull request Oct 7, 2024
Draft
copybara-service bot pushed a commit to tensorflow/tensorflow that referenced this pull request Oct 7, 2024
@sergey-kozub @tensorflower-gardener
PR #17754: [NFC] Extract common builder code into hlo_creation_utils
d5f533c 
Imported from GitHub PR openxla/xla#17754

Added `XlaComputationToHloComputation` helper function to `hlo_creation_utils` and replace the uses.

Copybara import of the project:

--
f9cbfd2cee78f6160eab9436121d4dfa2c89d168 by Sergey Kozub <skozub@nvidia.com>:

Extract common builder code into hlo_creation_utils

Merging this change closes #17754

PiperOrigin-RevId: 683116148
@sergey-kozub sergey-kozub deleted the skozub/xla_builder branch October 7, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuegel akuegel akuegel approved these changes

@olegshyshkov olegshyshkov Awaiting requested review from olegshyshkov

@golechwierowicz golechwierowicz Awaiting requested review from golechwierowicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergey-kozub @akuegel