Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Estimate mview sperson dataset in filesystem #123

Merged
merged 5 commits into from
Jun 12, 2023

Conversation

LazyBusyYang
Copy link
Member

@LazyBusyYang LazyBusyYang commented Jun 2, 2023

  1. Add HummanSMCDataCovnerter, converting SMCs to dataset in filesystem.
  2. Add a tool run_mview_sperson_estimator, running estimation on the files above. Also this tool addresses the requirements mentioned in the issue-118.
  3. Add datautils for better logger.

@LazyBusyYang LazyBusyYang changed the title Humman evaluation [Feature] Estimate mview sperson dataset in filesystem Jun 2, 2023
@LazyBusyYang LazyBusyYang requested a review from jiaqiAA June 2, 2023 07:27
@LazyBusyYang LazyBusyYang self-assigned this Jun 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #123 (5ea07ea) into main (32e7ddc) will decrease coverage by 0.66%.
The diff coverage is 14.55%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   61.19%   60.54%   -0.66%     
==========================================
  Files         178      180       +2     
  Lines       11097    11255     +158     
==========================================
+ Hits         6791     6814      +23     
- Misses       4306     4441     +135     
Flag Coverage Δ
unittests 60.54% <14.55%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...cap/data/data_converter/panoptic_data_converter.py 77.23% <ø> (ø)
xrmocap/utils/date_utils.py 0.00% <0.00%> (ø)
...p/data/data_converter/humman_smc_data_converter.py 14.28% <14.28%> (ø)
xrmocap/data/data_converter/builder.py 100.00% <100.00%> (ø)

smc_name = os.path.basename(smc_path)
if self.verbose:
self.logger.info('Extracting image relative path list' +
f' for scene {scene_idx}, file {smc_name}.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for users to pick the camera, not in order?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 0ef32be .

@jiaqiAA jiaqiAA merged commit 8b4931d into openxrlab:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants