-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install step copy feature on documentation is possibly incorrect #296
Comments
Thanks for the issue. Please open a PR. The fix should go in 07-copy-code.js. If we detect that the code being copied is shell commands, we should remove any leading |
Thanks for the insight @frangio. I have working code on my local but was wondering if I can get your opinion on an aspect of the solution. First, I noticed that the wrapping code has a class of Second, I noticed that for shell commands we are using Should I account for all possible shell languages and aliases (future proof) or just the currently used Thanks again! |
Using Let's try to support all aliases, because we're not being consistent across the docs and we use different kinds of language names. The following should suffice: |
Thanks @frangio, I opened the pull request. |
Documentation link: https://docs.openzeppelin.com/contracts/4.x/#install
When I press the copy icon this is saved to my machine
$ npm install @openzeppelin/contracts
. This throws an error on the terminal ofExpected a variable name after this $.
Because the copy command includes the
$
symbol. Is that expected or would it be better to only copy the executable part of the commandnpm install @openzeppelin/contracts
?I'm willing to make this update if it is a bug.
The text was updated successfully, but these errors were encountered: