Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

Fix Requires-spl syntax #27

Closed
behlendorf opened this issue May 17, 2016 · 2 comments
Closed

Fix Requires-spl syntax #27

behlendorf opened this issue May 17, 2016 · 2 comments

Comments

@behlendorf
Copy link
Contributor

After submitting a PR with the Requires-spl: keyword all subsequent build requests will use the same SPL commit instead of defaulting back to master. Restarting the build master resets the SPL dependency and is the current work around the issue.
@dinatale2
Copy link
Contributor

I believe the issue is with ss = self.codebases[codebase] in CustomSingleBranchScheduler.getCodebaseDict. I believe ss is a shallow copy of the dictionary pulled from self.codebases.

There are copy tools in python that can be used to make a deep copy. I'll make a pull request shortly. I'm not sure how we would be able to actually test it though.

@behlendorf
Copy link
Contributor Author

@dinatale2 if you can propose a patch I'm sure we can find some idle time on the buildbot to put it in place for testing.

dinatale2 added a commit to dinatale2/zfs-buildbot that referenced this issue May 20, 2016
@dinatale2
Prevent Require-spl dependency from persisting to other PRs
83b0bf1 
When a PR is submitted with the Requires-spl keyword, all
subsequent builds will use that SPL commit instead of
defaulting back to master. Corrected the
CustomSingleBranchScheduler.getCodebaseDict function
to make a deep copy of the codebase dictionary before
modifying it.

This closes openzfs#27.

Signed-off-by: Giuseppe Di Natale <dinatale2@llnl.gov>
@dinatale2 dinatale2 mentioned this issue May 20, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent Require-spl dependency from persisting to other PRs dinatale2/zfs-buildbot
2 participants
@behlendorf @dinatale2