Illumos 6096 - ZFS_SMB_ACL_RENAME needs to cleanup better

Dan McDonald · behlendorf · commit a4d179efa98f · 2016-02-05T11:28:53.000-08:00
6096 ZFS_SMB_ACL_RENAME needs to cleanup better Reviewed by: Matthew Ahrens <mahrens@delphix.com> Reviewed by: Gordon Ross <gordon.w.ross@gmail.com> Reviewed by: George Wilson <gwilson@zfsmail.com> Approved by: Robert Mustacchi <rm@joyent.com> References: https://www.illumos.org/issues/6096 illumos/illumos-gate@8f5190a5 Ported-by: Brian Behlendorf <behlendorf1@llnl.gov>
diff --git a/module/zfs/zfs_ioctl.c b/module/zfs/zfs_ioctl.c
@@ -4847,6 +4847,7 @@ zfs_ioc_smb_acl(zfs_cmd_t *zc)
 		if ((error = get_nvlist(zc->zc_nvlist_src,
 		    zc->zc_nvlist_src_size, zc->zc_iflags, &nvlist)) != 0) {
 			VN_RELE(vp);
+			VN_RELE(ZTOV(sharedir));
 			ZFS_EXIT(zsb);
 			return (error);
 		}

Original file line number	Diff line number	Diff line change
`@@ -4847,6 +4847,7 @@ zfs_ioc_smb_acl(zfs_cmd_t *zc)`
`4847`	`4847`	`if ((error = get_nvlist(zc->zc_nvlist_src,`
`4848`	`4848`	`zc->zc_nvlist_src_size, zc->zc_iflags, &nvlist)) != 0) {`
`4849`	`4849`	`VN_RELE(vp);`
	`4850`	`+ VN_RELE(ZTOV(sharedir));`
`4850`	`4851`	`ZFS_EXIT(zsb);`
`4851`	`4852`	`return (error);`
`4852`	`4853`	`}`