Add "zstd-fast" to help options for "compression" property #11670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value does work as expected, and is documented in the manpage. Signed-off-by: Jake Howard <git@theorangeone.net>
behlendorf
added
Status: Code Review Needed
|
(I don't think the test failures here are related to my change. If they are, I'm going to need some help deciphering the CI output) |
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
that referenced
this pull request
Mar 5, 2021
This value does work as expected, and is documented in the manpage. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jake Howard <git@theorangeone.net> Closes #11670
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
This value does work as expected, and is documented in the manpage. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jake Howard <git@theorangeone.net> Closes openzfs#11670
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
This value does work as expected, and is documented in the manpage. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jake Howard <git@theorangeone.net> Closes openzfs#11670
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The "zstd-fast" option exists, and is documented in some places. Without looking specifically at the manpages or source code, it's a difficult option to find.
Description
Add "zstd-fast" as a documented possible value when showing error text or enumerating all properties and possible values.
How Has This Been Tested?
Using
zfs set -o compression=zstd-fast tankworks as expected, it's just updating the help text.Types of changes
Checklist:
I have added tests to cover my changes.I have run the ZFS Test Suite with this change applied.Signed-off-by.