Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD: Update dataset_kstats for zvols in dev mode. #12097

Merged
merged 1 commit into from
May 26, 2021
Merged

FreeBSD: Update dataset_kstats for zvols in dev mode. #12097

merged 1 commit into from
May 26, 2021

Conversation

amotin
Copy link
Member

@amotin amotin commented May 21, 2021

Previous commit added accounting for geom mode, but not for dev.
In geom mode we actually have GEOM statistics, while in dev mode
additional accounting actually makes more sense.

How Has This Been Tested?

Run fio on zvols in dev mode. Observed sysctl kstat.zfs..dataset.objset-.* previously being zero incrementing.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
FreeBSD: Update dataset_kstats for zvols in dev mode.
68b5310 
Previous commit added accounting for geom mode, but not for dev.
In geom mode we actually have GEOM statistics, while in dev mode
additional accounting actually makes more sense.

Signed-off-by: Alexander Motin <mav@FreeBSD.org>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label May 21, 2021
@amotin amotin requested a review from a user May 21, 2021 17:02
@ghost ghost added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 26, 2021
@tonynguien tonynguien merged commit c71a2bb into openzfs:master May 26, 2021
behlendorf pushed a commit to behlendorf/zfs that referenced this pull request May 28, 2021
@amotin @behlendorf
FreeBSD: Update dataset_kstats for zvols in dev mode
a7bb2da 
Previous commit added accounting for geom mode, but not for dev.
In geom mode we actually have GEOM statistics, while in dev mode
additional accounting actually makes more sense.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Closes openzfs#12097
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@amotin
FreeBSD: Update dataset_kstats for zvols in dev mode
e8814a7 
Previous commit added accounting for geom mode, but not for dev.
In geom mode we actually have GEOM statistics, while in dev mode
additional accounting actually makes more sense.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Alexander Motin <mav@FreeBSD.org>
Closes openzfs#12097
@amotin amotin deleted the dataset_kstats branch August 24, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees

@tonynguien tonynguien

Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amotin @behlendorf @tonynguien