Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence uninitialized warnings in dsl_dataset.c #13083

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Silence uninitialized warnings in dsl_dataset.c #13083

merged 1 commit into from
Feb 14, 2022

Conversation

rincebrain
Copy link
Contributor

Motivation and Context

On at least Debian gcc 10.2.1-6, this produces a warning (and, on --enable-debug, dies with an error).

I think I've written this patch at least 5 times now in different PRs before remembering to submit it.

Description

= 0

How Has This Been Tested?

It built, and ran without crashing unexpectedly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

rincebrain added a commit to rincebrain/zfs that referenced this pull request Feb 11, 2022
@rincebrain
Ask libtool to stop hiding some errors
7b42385 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
rincebrain added a commit to rincebrain/zfs that referenced this pull request Feb 11, 2022
@rincebrain
Ask libtool to stop hiding some errors
35bd9a9 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@rincebrain rincebrain mentioned this pull request Feb 11, 2022
Merged
13 tasks
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Feb 11, 2022
rincebrain added a commit to rincebrain/zfs that referenced this pull request Feb 11, 2022
@rincebrain
Ask libtool to stop hiding some errors
bdab247 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@rincebrain
Silence uninitialized warnings in dsl_dataset.c
32eb0d9 
On newer compilers, dsl_dataset.c now warns (or, on DEBUG, errors)
on uninitialized variable usage.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
@behlendorf behlendorf merged commit dec1eef into openzfs:master Feb 14, 2022
rincebrain added a commit to rincebrain/zfs that referenced this pull request Feb 15, 2022
@rincebrain
Ask libtool to stop hiding some errors
dca349b 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Feb 15, 2022
@rincebrain @tonyhutter
Silence uninitialized warnings in dsl_dataset.c
d12cd2d 
On newer compilers, dsl_dataset.c now warns (or, on DEBUG, errors)
on uninitialized variable usage.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13083
rincebrain added a commit to rincebrain/zfs that referenced this pull request Feb 16, 2022
@rincebrain
Ask libtool to stop hiding some errors
0ce1ed7 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
rincebrain added a commit to rincebrain/zfs that referenced this pull request Mar 11, 2022
@rincebrain
Ask libtool to stop hiding some errors
d80c3e5 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
rincebrain added a commit to rincebrain/zfs that referenced this pull request Mar 31, 2022
@rincebrain
Ask libtool to stop hiding some errors
1274812 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
behlendorf pushed a commit that referenced this pull request Mar 31, 2022
@rincebrain
Ask libtool to stop hiding some errors
6a2dda8 
For #13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes #13086
BrainSlayer pushed a commit to BrainSlayer/zfs that referenced this pull request Apr 11, 2022
@rincebrain @BrainSlayer
Ask libtool to stop hiding some errors
58b1c44 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@rincebrain @nicman23
Silence uninitialized warnings in dsl_dataset.c
4f59369 
On newer compilers, dsl_dataset.c now warns (or, on DEBUG, errors)
on uninitialized variable usage.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13083
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@rincebrain @nicman23
Ask libtool to stop hiding some errors
27b8cac 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@rincebrain @nicman23
Silence uninitialized warnings in dsl_dataset.c
251d87f 
On newer compilers, dsl_dataset.c now warns (or, on DEBUG, errors)
on uninitialized variable usage.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13083
nicman23 pushed a commit to nicman23/zfs that referenced this pull request Aug 22, 2022
@rincebrain @nicman23
Ask libtool to stop hiding some errors
6a210d4 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 2, 2022
@rincebrain @lundman
Ask libtool to stop hiding some errors
820a4dd 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
beren12 pushed a commit to beren12/zfs that referenced this pull request Sep 19, 2022
@rincebrain @beren12
Ask libtool to stop hiding some errors
e6acddf 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Sep 21, 2022
@rincebrain @tonyhutter
Ask libtool to stop hiding some errors
ebbbe01 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
cfd51a7 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
cb0361d 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
88635d2 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
4dfe362 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
fc23cdc 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
e0e1e70 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
5f7fc83 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
7d46511 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
bf07220 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
6289969 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
eab90d9 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
d0df3d9 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
36b6630 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
2e2929c 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
andrewc12 pushed a commit to andrewc12/openzfs that referenced this pull request Sep 23, 2022
@rincebrain @andrewc12
Ask libtool to stop hiding some errors
b93edf8 
For openzfs#13083, curiously, it did not print the actual error, just
that the compile failed with "Error 1".

In theory, this flag should cause it to report errors twice sometimes.
In practice, I'm pretty okay with reporting some twice if it avoids
reporting some never.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Damian Szuberski <szuberskidamian@gmail.com>
Signed-off-by: Rich Ercolani <rincebrain@gmail.com>
Closes openzfs#13086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rincebrain @behlendorf