Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD: Fix potential boot panic with bad label #14291

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 15, 2022

Motivation and Context

https://forums.FreeBSD.org/threads/nvme-adapter-with-hp-ex900-ssd-pci-e-nvme.85816/post-590379
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256368
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=268116

vdev_geom_read_pool_label() can leave NULL in configs when it cannot read a label.
We then expect to be able to read the config and panic.

Description

Check for NULL and skip it when iterating through configs to generate rootconf.

How Has This Been Tested?

An early version of this fix was tested https://forums.FreeBSD.org/threads/nvme-adapter-with-hp-ex900-ssd-pci-e-nvme.85816/post-590379

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ghost
Copy link
Author

ghost commented Dec 15, 2022

Needs fixing in 2.1, too.

@ghost ghost added the Status: Code Review Needed Ready for review and testing label Dec 15, 2022
@ghost ghost requested a review from amotin December 21, 2022 19:23
@ghost
Copy link
Author

ghost commented Dec 21, 2022

  • Rebased
  • Check for the initialized best_txg value rather than the uninitialized best_cfg

vdev_geom_read_pool_label() can leave NULL in configs.  Check for it
and skip consistently when generating rootconf.

Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
@ghost ghost added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Dec 22, 2022
@behlendorf behlendorf merged commit dc8c2f6 into openzfs:master Dec 22, 2022
@ghost ghost deleted the hole-panic branch December 22, 2022 19:56
ghost pushed a commit to truenas/zfs that referenced this pull request Dec 22, 2022
vdev_geom_read_pool_label() can leave NULL in configs.  Check for it
and skip consistently when generating rootconf.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#14291
(cherry picked from commit dc8c2f6)
behlendorf pushed a commit that referenced this pull request Jan 5, 2023
vdev_geom_read_pool_label() can leave NULL in configs.  Check for it
and skip consistently when generating rootconf.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes #14291
(cherry picked from commit dc8c2f6)
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Mar 3, 2023
vdev_geom_read_pool_label() can leave NULL in configs.  Check for it
and skip consistently when generating rootconf.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
Closes openzfs#14291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants