initramfs: fix for mountpoint=legacy check #14604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behlendorf
approved these changes
Mar 10, 2023
ryao
approved these changes
Mar 10, 2023
|
Can you please and your signed-off-by to this commit and force update the PR ( |
We need to clear mountpoint only after checking it. Signed-off-by: ofthesun9 <olivier@ofthesun.net>
ofthesun9
force-pushed
the
fix-initramfs-mountpoint-legacy
branch
from
2dd6b28
to
cb0c004
Compare
behlendorf
added
Status: Accepted
behlendorf
pushed a commit
to behlendorf/zfs
that referenced
this pull request
Mar 14, 2023
We need to clear mountpoint only after checking it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: ofthesun9 <olivier@ofthesun.net> Closes openzfs#14599 Closes openzfs#14604
7 tasks
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 17, 2023
We need to clear mountpoint only after checking it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: ofthesun9 <olivier@ofthesun.net> Closes openzfs#14599 Closes openzfs#14604
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 17, 2023
We need to clear mountpoint only after checking it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: ofthesun9 <olivier@ofthesun.net> Closes openzfs#14599 Closes openzfs#14604
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 17, 2023
We need to clear mountpoint only after checking it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: ofthesun9 <olivier@ofthesun.net> Closes openzfs#14599 Closes openzfs#14604
lundman
pushed a commit
to openzfsonwindows/openzfs
that referenced
this pull request
Mar 17, 2023
We need to clear mountpoint only after checking it. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Yao <richard.yao@alumni.stonybrook.edu> Signed-off-by: ofthesun9 <olivier@ofthesun.net> Closes openzfs#14599 Closes openzfs#14604
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
in initramfs script, we need to use mount.zfs (and not mount.zfs -o zfsutils) for dataset where mountpoint=legacy.
eb823cb is adding this check but we need to do this before clearing the mountpoint variable.
Closes #14599
Description
Just moving "clear the mountpoint variable line" after the check.
How Has This Been Tested?
Tested on my system. I can boot my ZFS on root system without being dropped to the shell
Types of changes
Checklist:
Signed-off-by.