Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce bloat in ereport.fs.zfs.checksum events #15052

Closed
wants to merge 2 commits into from
Closed

Reduce bloat in ereport.fs.zfs.checksum events #15052

wants to merge 2 commits into from

Commits on Jul 20, 2023

  1. Don't emit checksum histograms in ereport.fs.zfs.checksum events 

    The checksum histograms were intended to be used with ATA and parallel
SCSI, which are obsolete.  With modern storage hardware, they will
almost always look like white noise; all bits will be wrong.  They only
serve to bloat the event.  That's a particular problem on FreeBSD, where
events must fit into a 1016 byte buffer.

This fixes issue openzfs#14717 for RAIDZ pools, but not for mirror pools.

Sponsored-by:	Axcient
Signed-off-by:	Alan Somers <asomers@gmail.com>
    @asomers
    asomers committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    db97069 View commit details
    Browse the repository at this point in the history

  2. Don't emit cksum_{actual_expected} in ereport.fs.zfs.checksum events 

    With anything but fletcher-4, even a tiny change in the input will cause
the checksum value to change completely.  So knowing the actual and
expected checksums doesn't provide much more information than "they
don't match".  The harm in sending them is simply that they bloat the
event.  In particular, on FreeBSD the event must fit into a 1016 byte
buffer.

Fixes openzfs#14717 for mirrored pools.

Sponsored-by:   Axcient
Signed-off-by:  Alan Somers <asomers@gmail.com>
    @asomers
    asomers committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    51c97d5 View commit details
    Browse the repository at this point in the history