Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arc_summary: "ARC prefetch metadata accesses:" appears twice in the output. #15427

Merged
merged 1 commit into from
Oct 23, 2023
Merged

arc_summary: "ARC prefetch metadata accesses:" appears twice in the output. #15427

merged 1 commit into from
Oct 23, 2023
+1 −1

Conversation

ofthesun9
Copy link
Contributor

"ARC prefetch metadata accesses:" appears twice in the output.
The first occurence should be "ARC prefetch data accesses:"

Motivation and Context

fixes #15426

Description

Changed the title of the section in cmd/arc_summary

How Has This Been Tested?

tested locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ofthesun9
"ARC prefetch metadata accesses:" appears twice in the output.
7b66294 
The first occurence should be "ARC prefetch data accesses:"

Signed-off-by: ofthesun9 <olivier@ofthesun.net>
@ofthesun9 ofthesun9 changed the title "ARC prefetch metadata accesses:" appears twice in the output. arc_summary: "ARC prefetch metadata accesses:" appears twice in the output. Oct 20, 2023
amotin
amotin approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Oct 20, 2023
@behlendorf behlendorf merged commit e579092 into openzfs:master Oct 23, 2023
22 of 25 checks passed
ixhamza pushed a commit to truenas/zfs that referenced this pull request Nov 20, 2023
@ofthesun9 @tonyhutter
"ARC prefetch metadata accesses:" appears twice in the output.
86c3ed4 
The first occurrence should be "ARC prefetch data accesses:"

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: ofthesun9 <olivier@ofthesun.net>
Closes openzfs#15427
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Dec 12, 2023
@ofthesun9 @lundman
"ARC prefetch metadata accesses:" appears twice in the output.
ee8cf56 
The first occurrence should be "ARC prefetch data accesses:"

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: ofthesun9 <olivier@ofthesun.net>
Closes openzfs#15427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

arc_summary reports "ARC demand metadata accesses:" instead of "ARC demand data accesses:"
3 participants
@ofthesun9 @behlendorf @amotin