Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zdb: fix FreeBSD build failure #16252

Merged
merged 1 commit into from
Jun 7, 2024
Merged

zdb: fix FreeBSD build failure #16252

merged 1 commit into from
Jun 7, 2024

Conversation

ixhamza
Copy link
Contributor

@ixhamza ixhamza commented Jun 6, 2024 •
edited
Loading

Motivation and Context

This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Description

https://build.openzfs.org/builders/FreeBSD%20stable%2F13%20amd64%20%28TEST%29/builds/2010/steps/shell_1/logs/make

How Has This Been Tested?

  • CI and buildboot tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@ixhamza
zdb: fix FreeBSD build failure
78d01d9 
This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
@ixhamza ixhamza marked this pull request as ready for review June 6, 2024 21:25
@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label Jun 7, 2024
@behlendorf behlendorf merged commit b558f0a into openzfs:master Jun 7, 2024
18 of 25 checks passed
@ixhamza ixhamza deleted the zdb-clang18-build-fix branch June 7, 2024 00:03
ixhamza added a commit to truenas/zfs that referenced this pull request Jun 13, 2024
@ixhamza
zdb: fix FreeBSD build failure
ba05363 
This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#16252
ixhamza added a commit to truenas/zfs that referenced this pull request Jun 13, 2024
@ixhamza
zdb: fix FreeBSD build failure
560f4ba 
This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#16252
ixhamza added a commit to truenas/zfs that referenced this pull request Jun 13, 2024
@ixhamza
zdb: fix FreeBSD build failure
5008a4a 
This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#16252
ixhamza added a commit to truenas/zfs that referenced this pull request Jun 13, 2024
@ixhamza
zdb: fix FreeBSD build failure
680a1f5 
This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#16252
ixhamza added a commit to truenas/zfs that referenced this pull request Aug 13, 2024
@ixhamza
zdb: fix FreeBSD build failure
8702780 
This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#16252
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@ixhamza @lundman
zdb: fix FreeBSD build failure
9b42777 
This fixes FreeBSD build failure with clang-18 after 23a489a got merged.

Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ameer Hamza <ahamza@ixsystems.com>
Closes openzfs#16252
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robn robn robn approved these changes

@behlendorf behlendorf behlendorf approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ixhamza @robn @behlendorf @amotin