Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux 6.9 compat for ZFS 2.1.x #16286

Draft
wants to merge 3 commits into
base: zfs-2.1.16-staging
Choose a base branch
from
Draft

Linux 6.9 compat for ZFS 2.1.x #16286

wants to merge 3 commits into from

Conversation

RaitoBezarius
Copy link
Contributor

@RaitoBezarius RaitoBezarius commented Jun 20, 2024 •
edited
Loading

Motivation and Context

This brings Linux 6.9 compat for ZFS 2.1.x.

Description

Applies the deprecations of upstream kernel.

How Has This Been Tested?

Untested at the moment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@RaitoBezarius
Linux 6.9 compat: bdev_open_by_path
b1f9a75 
Support the new `bdev_open_by_path` API introduced in
https://lore.kernel.org/all/20240123-vfs-bdev-file-v2-0-adbd023e19cc@kernel.org/.

Signed-off-by: Ryan Lahfa <ryan@lahfa.xyz>
@RaitoBezarius
Linux 6.9 compat: fput for block device release
08f57a3 
With new file-driven API, it is sufficient to `fput` the block device
handle to release it.

Signed-off-by: Ryan Lahfa <ryan@lahfa.xyz>
@RaitoBezarius
Linux 6.9 compat: blk_alloc_disk takes 2 args
980aca4 
Now, it takes queue limits, this is a trivial implementation
with no queue limits, implementing proper queue limits is left as an
exercise to the reader.

Signed-off-by: Ryan Lahfa <ryan@lahfa.xyz>
@RaitoBezarius
Copy link
Contributor Author

Hmm, it doesn't seem to pass ZTS, I may have introduced a problem somewhere.

@robn
Copy link
Member

robn commented Jun 21, 2024

This looks at least in part like a backport of #16033, with comments and credits removed. Is it? If so, please just use a cherry-pick of those commits.

You will likely also need #16282.

@RaitoBezarius
Copy link
Contributor Author

Well, I didn't read this PR, I wrote myself, I am completely fine with starting anew from there and back porting it, I was just not aware of it.

@RaitoBezarius
Copy link
Contributor Author

I will start from your work, thanks for mentioning it!

@tonyhutter
Copy link
Contributor

Any chance we could also convince you to pull in the 6.8 patches as well? I believe zfs-2.1.15 currently supports up to 6.7.

@RaitoBezarius
Copy link
Contributor Author

Of course!

@tomchiverton
Copy link

Shouldn't this have updated Linux-Maximum: 6.8 in https://github.com/openzfs/zfs/blob/master/META ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RaitoBezarius @robn @tonyhutter @tomchiverton