Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

one-word manpage correction: snapshot->rollback #16294

Merged
merged 1 commit into from
Jul 12, 2024
Merged

one-word manpage correction: snapshot->rollback #16294

merged 1 commit into from
Jul 12, 2024

Conversation

a1ea321
Copy link
Contributor

@a1ea321 a1ea321 commented Jun 24, 2024

This commit fixes what is probably a copy-paste mistake. The dracut.zfs manpage claims that the bootfs.rollback option executes zfs snapshot -Rf. zfs snapshot does not have a -R option. zfs rollback does.

How Has This Been Tested?

Not tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@a1ea321
one-word manpage correction: snapshot->rollback
49b69fa 
This commit fixes what is probably a copy-paste mistake. The
`dracut.zfs` manpage claims that the `bootfs.rollback` option executes
`zfs snapshot -Rf`. `zfs snapshot` does not have a `-R` option. `zfs
rollback` does.

Signed-off-by: Alphan Yılmaz <alphanyilmaz@gmail.com>
@tonyhutter tonyhutter merged commit 398e675 into openzfs:master Jul 12, 2024
22 of 25 checks passed
robn pushed a commit to robn/zfs that referenced this pull request Jul 17, 2024
@a1ea321 @tonyhutter
one-word manpage correction: snapshot->rollback (openzfs#16294)
08da054 
This commit fixes what is probably a copy-paste mistake. The
`dracut.zfs` manpage claims that the `bootfs.rollback` option executes
`zfs snapshot -Rf`. `zfs snapshot` does not have a `-R` option. `zfs
rollback` does.

Signed-off-by: Alphan Yılmaz <alphanyilmaz@gmail.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
calccrypto pushed a commit to hpc/zfs that referenced this pull request Jul 17, 2024
@a1ea321 @calccrypto
one-word manpage correction: snapshot->rollback (openzfs#16294)
07c40e8 
This commit fixes what is probably a copy-paste mistake. The
`dracut.zfs` manpage claims that the `bootfs.rollback` option executes
`zfs snapshot -Rf`. `zfs snapshot` does not have a `-R` option. `zfs
rollback` does.

Signed-off-by: Alphan Yılmaz <alphanyilmaz@gmail.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
@a1ea321 a1ea321 deleted the manpagefix branch July 27, 2024 19:19
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@a1ea321 @lundman
one-word manpage correction: snapshot->rollback (openzfs#16294)
7c4c619 
This commit fixes what is probably a copy-paste mistake. The
`dracut.zfs` manpage claims that the `bootfs.rollback` option executes
`zfs snapshot -Rf`. `zfs snapshot` does not have a `-R` option. `zfs
rollback` does.

Signed-off-by: Alphan Yılmaz <alphanyilmaz@gmail.com>
Reviewed-by: Rob Norris <rob.norris@klarasystems.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

@gmelikov gmelikov gmelikov approved these changes

@robn robn robn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a1ea321 @robn @gmelikov @tonyhutter