Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZTS: Make do_vol_test() more deterministic #16379

Merged
merged 1 commit into from
Jul 24, 2024
Merged

ZTS: Make do_vol_test() more deterministic #16379

merged 1 commit into from
Jul 24, 2024

Conversation

amotin
Copy link
Member

@amotin amotin commented Jul 22, 2024

  • Explicitly disable compression since mkfile uses a zero buffer.
  • Explicitly sync file systems instead of waiting for timeout.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
ZTS: Make do_vol_test() more deterministic
84f3cda 
 - Explicitly disable compression since mkfile uses a zero buffer.
 - Explicitly sync file systems instead of waiting for timeout.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
@tonyhutter tonyhutter mentioned this pull request Jul 24, 2024
Open
@tonyhutter
Copy link
Contributor

I'm really happy to see that zfs_copies_006_pos passed on FreeBSD 13 with this PR. That test has had a very low success rate on FreeBSD.

@tonyhutter tonyhutter merged commit 82f281a into openzfs:master Jul 24, 2024
23 of 25 checks passed
@amotin amotin deleted the do_vol_test branch July 24, 2024 16:35
@mcmilk
Copy link
Contributor

mcmilk commented Jul 24, 2024

LOL, I just figured this also out, but didn't see the pull request :-)

tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jul 24, 2024
@amotin @tonyhutter
ZTS: Make do_vol_test() more deterministic (openzfs#16379)
66fd9b2 
- Explicitly disable compression since mkfile uses a zero buffer.
 - Explicitly sync file systems instead of waiting for timeout.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Jul 24, 2024
@amotin @tonyhutter
ZTS: Make do_vol_test() more deterministic (openzfs#16379)
a1f2d61 
- Explicitly disable compression since mkfile uses a zero buffer.
 - Explicitly sync file systems instead of waiting for timeout.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
tonyhutter pushed a commit that referenced this pull request Aug 6, 2024
@amotin @tonyhutter
ZTS: Make do_vol_test() more deterministic (#16379)
dd5de55 
- Explicitly disable compression since mkfile uses a zero buffer.
 - Explicitly sync file systems instead of waiting for timeout.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
lundman pushed a commit to openzfsonwindows/openzfs that referenced this pull request Sep 4, 2024
@amotin @lundman
ZTS: Make do_vol_test() more deterministic (openzfs#16379)
8b789a0 
- Explicitly disable compression since mkfile uses a zero buffer.
 - Explicitly sync file systems instead of waiting for timeout.

Signed-off-by:	Alexander Motin <mav@FreeBSD.org>
Sponsored by:	iXsystems, Inc.
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyhutter tonyhutter tonyhutter approved these changes

@gmelikov gmelikov gmelikov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amotin @tonyhutter @mcmilk @gmelikov