Update migration tests #5315
Update migration tests #5315
Conversation
|
@legend-hua, thanks for your PR! By analyzing the history of the files in this pull request, we identified @behlendorf and @sydneyvanda to be potential reviewers. |
| @@ -64,10 +45,4 @@ log_must $ZFS set mountpoint=$TESTDIR $TESTPOOL/$TESTFS | |||
| $RM -rf $NONZFS_TESTDIR || log_unresolved Could not remove $NONZFS_TESTDIR | |||
| $MKDIR -p $NONZFS_TESTDIR || log_unresolved Could not create $NONZFS_TESTDIR | |||
|
|
|||
| $ECHO "y" | $NEWFS -v ${DEV_DSKDIR}/$NONZFSSIDE_DISK | |||
There was a problem hiding this comment.
For Linux $NEWFS is defined to be /sbin/mke2fs so this should work and create a Linux filesystem which can be used in place of UFS for the test. Maybe the path is wrong here and that's why it's failing. But there shouldn't be and reason to remove this code and with minimal modification should work for Linux.
There was a problem hiding this comment.
@behlendorf We have two linux which centos 6.1 and customize linux. I want that the migration tests can be run on my environment, so that only considering the native linux.
Thanks for your advice, I try to fix it
| @@ -34,12 +34,12 @@ | |||
|
|
|||
| # | |||
| # DESCRIPTION: | |||
| # Migrating test file from ZFS fs to UFS fs using tar. | |||
| # Migrating test file from ZFS fs to Linux native fs using tar. | |||
There was a problem hiding this comment.
$NEWFS_DEFAULT_FS is defined to be FS type which should be used.
legend-hua
force-pushed
the
EC
branch
2 times, most recently
from
35d803a
to
0bb073f
Compare
Due to the instability of the migration tests, the test will skip. The migration tests focus on migrating test file from fs to ZFS fs. We can create zpool and ext2 directly by loop device, rather than by set_partition Signed-off-by: legend-hua liu.hua130@zte.com.cn
|
@sydneyvanda @jsalinasintel could you review this. I believe the goal here is to get these tests running on CentOS 6 where they're usually skipped. |
|
@legend-hua @behlendorf @jsalinasintel - this looks good to me. I tested this patch on CentOS 6.8 and worked fine. I also added a fix for the incorrect error messages "lsblk: /dev/mapper/loop0: not a block device" as seen above in #5350. |
|
@sydneyvanda [root@brs82 /]# lsb_release -a [root@root ~]# lsb_release -a |
Due to the instability of the migration tests, the test will skip.
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/setup (run as root) [00:00] [SKIP]
03:08:56.97 lsblk: /dev/mapper/loop0: not a block device
03:08:56.97 lsblk: /dev/mapper/loop0: not a block device
03:08:56.97 lsblk: /dev/mapper/loop0: not a block device
03:08:56.98 lsblk: /dev/mapper/loop1: not a block device
03:08:56.98 lsblk: /dev/mapper/loop1: not a block device
03:08:56.99 Only partitionable physical disks can be used
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_001_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_002_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_003_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_004_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_005_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_006_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_007_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_008_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_009_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_010_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_011_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/migration_012_pos (run as root) [00:00] [SKIP]
Test: /usr/share/zfs/zfs-tests/tests/functional/migration/cleanup (run as root) [00:00] [PASS]
03:08:57.02 lsblk: /dev/mapper/loop0: not a block device
03:08:57.02 lsblk: /dev/mapper/loop0: not a block device
03:08:57.03 lsblk: /dev/mapper/loop0: not a block device
03:08:57.03 lsblk: /dev/mapper/loop1: not a block device
03:08:57.03 lsblk: /dev/mapper/loop1: not a block device
03:08:57.05 NOTE: Pool does not exist. (testpool.26868)
03:08:57.05 lsblk: /dev/mapper/loop0: not a block device
03:08:57.13 SUCCESS: /sbin/zpool create -f foopool3915 loop0 loop1
03:08:57.16 SUCCESS: cleanup_devices loop0 loop1
The migration tests focus on migrating test file from fs to ZFS fs.
We can use linux native fs instead of UFS fs, so that reducing complexity
of setup.